From d50a22d6a6466b8dc1c2fbd90a45a8cd295c520d Mon Sep 17 00:00:00 2001 From: Danny Al-Gaaf Date: Tue, 12 Feb 2013 17:20:19 +0100 Subject: [PATCH] ceph_authtool.cc: use empty() instead of size() Use empty() since it should be prefered as it has, following the standard, a constant time complexity regardless of the containter type. The same is not guaranteed for size(). warning from cppchecker was: [src/ceph_authtool.cc:124]: (performance) Possible inefficient checking for 'caps' emptiness. [src/ceph_authtool.cc:237]: (performance) Possible inefficient checking for 'caps' emptiness. Signed-off-by: Danny Al-Gaaf --- src/ceph_authtool.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ceph_authtool.cc b/src/ceph_authtool.cc index d4d205a4fa14..3075d9c69a78 100644 --- a/src/ceph_authtool.cc +++ b/src/ceph_authtool.cc @@ -121,7 +121,7 @@ int main(int argc, const char **argv) !add_key.empty() || list || !caps_fn.empty() || - caps.size() || + !caps.empty() || set_auid || print_key || create_keyring || @@ -234,7 +234,7 @@ int main(int argc, const char **argv) keyring.set_caps(ename, caps); modified = true; } - if (caps.size()) { + if (!caps.empty()) { keyring.set_caps(ename, caps); modified = true; } -- 2.47.3