From d5bed26f0194932f094fef0ee8550cbf36b64181 Mon Sep 17 00:00:00 2001 From: Jianpeng Ma Date: Tue, 28 Feb 2017 00:41:26 +0800 Subject: [PATCH] os/aio: remove the redundant memset(struct iocb) In fact, io_prep_read/write/pwritev/preadv do the memset(struct iocb). So no need do it. Signed-off-by: Jianpeng Ma --- src/os/filestore/FileJournal.h | 1 - src/os/fs/FS.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/os/filestore/FileJournal.h b/src/os/filestore/FileJournal.h index c804f354d58fa..00fc4b484489e 100644 --- a/src/os/filestore/FileJournal.h +++ b/src/os/filestore/FileJournal.h @@ -257,7 +257,6 @@ private: aio_info(bufferlist& b, uint64_t o, uint64_t s) : iov(NULL), done(false), off(o), len(b.length()), seq(s) { bl.claim(b); - memset((void*)&iocb, 0, sizeof(iocb)); } ~aio_info() { delete[] iov; diff --git a/src/os/fs/FS.h b/src/os/fs/FS.h index fdda7dabfc566..0dc8dcb3764f0 100644 --- a/src/os/fs/FS.h +++ b/src/os/fs/FS.h @@ -65,7 +65,6 @@ public: boost::intrusive::list_member_hook<> queue_item; aio_t(void *p, int f) : priv(p), fd(f), offset(0), length(0), rval(-1000) { - memset(&iocb, 0, sizeof(iocb)); } void pwritev(uint64_t _offset, uint64_t len) { -- 2.39.5