From d73eb895cdc792ddef2626643e61c1521cf53434 Mon Sep 17 00:00:00 2001 From: Samuel Just Date: Wed, 27 Aug 2014 16:21:41 -0700 Subject: [PATCH] PG::can_discard_op: do discard old subopreplies Otherwise, a sub_op_reply from a previous interval can stick around until we either one day go active again and get rid of it or delete the pg which is holding it on its waiting_for_active list. While it sticks around futily waiting for the pg to once more go active, it will cause harmless slow request warnings. Fixes: #9259 Backport: firefly Signed-off-by: Samuel Just (cherry picked from commit ae3d87348ca4e2dde809c9593b0d54ce0469f7a0) --- src/osd/PG.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/osd/PG.cc b/src/osd/PG.cc index 6394e1bd4be1f..8f4ef2c8bf77f 100644 --- a/src/osd/PG.cc +++ b/src/osd/PG.cc @@ -5138,7 +5138,7 @@ bool PG::can_discard_request(OpRequestRef op) case MSG_OSD_PG_PUSH_REPLY: return can_discard_replica_op(op); case MSG_OSD_SUBOPREPLY: - return false; + return can_discard_replica_op(op); case MSG_OSD_EC_WRITE: return can_discard_replica_op(op); -- 2.39.5