From d746534ad521f1a132354646936a9e27aea0a4c3 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Tue, 12 May 2020 11:53:14 -0500 Subject: [PATCH] ceph-dedup-tool: warn on hash collision Signed-off-by: Sage Weil --- src/tools/ceph_dedup_tool.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/tools/ceph_dedup_tool.cc b/src/tools/ceph_dedup_tool.cc index d41177ce8c9..ddf3efdabd2 100644 --- a/src/tools/ceph_dedup_tool.cc +++ b/src/tools/ceph_dedup_tool.cc @@ -389,9 +389,11 @@ void EstimateDedupRatio::add_chunk_fp_to_stat(bufferlist &chunk) auto p = local_chunk_statistics.find(fp); if (p != local_chunk_statistics.end()) { - uint64_t count = p->second.first; - count++; - local_chunk_statistics[fp] = make_pair(count, chunk.length()); + p->second.first++; + if (p->second.second != chunk.length()) { + cerr << "warning: hash collision on " << fp << ": was " << p->second.second + << " now " << chunk.length() << std::endl; + } } else { local_chunk_statistics[fp] = make_pair(1, chunk.length()); } -- 2.39.5