From d856db33571cee3c323c2329a7aef92c543e0f1f Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Tue, 24 Sep 2019 15:13:51 +0800 Subject: [PATCH] test/pybind/test_ceph_argparse.py: add a test for "osd pool create" Signed-off-by: Kefu Chai --- src/test/pybind/test_ceph_argparse.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/test/pybind/test_ceph_argparse.py b/src/test/pybind/test_ceph_argparse.py index c7d3022e58a5d..21df4bee049aa 100755 --- a/src/test/pybind/test_ceph_argparse.py +++ b/src/test/pybind/test_ceph_argparse.py @@ -1068,6 +1068,15 @@ class TestOSD(TestArgparse): 'erasure', 'A-Za-z0-9-_.', 'ruleset^^']) self.assert_valid_command(['osd', 'pool', 'create', 'poolname']) assert_equal({}, validate_command(sigdict, ['osd', 'pool', 'create'])) + # invalid pg_num and pgp_num, like "-1", could spill over to + # erasure_code_profile and rule as they are valid profile and rule + # names, so validate_commands() cannot identify such cases. + # but if they are matched by profile and rule, the "rule" argument + # won't get a chance to be matched anymore. + assert_equal({}, validate_command(sigdict, ['osd', 'pool', 'create', + 'poolname', + '-1', '-1', + 'ruleset'])) assert_equal({}, validate_command(sigdict, ['osd', 'pool', 'create', 'poolname', '128', '128', -- 2.39.5