From d9cdd6175b996ac4e7b65354dbb49c74f482b7ed Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Tue, 1 Mar 2022 22:38:49 +0800 Subject: [PATCH] crimson/osd: use reference when structured binding to silence warning from clang13 with -std=c++20, like ceph/src/crimson/osd/replicated_recovery_backend.cc:1098:21: warning: loop variable '[off, len]' creates a copy from type 'const std::pair' [-Wrange-loop-construct] for (const auto [off, len] : extents) { ^ ceph/src/crimson/osd/replicated_recovery_backend.cc:1098:10: note: use reference type 'const std::pair &' to prevent copying for (const auto [off, len] : extents) { ^~~~~~~~~~~~~~~~~~~~~~~ & Signed-off-by: Kefu Chai --- src/crimson/osd/replicated_recovery_backend.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/crimson/osd/replicated_recovery_backend.cc b/src/crimson/osd/replicated_recovery_backend.cc index dae4c8ef853f8..12b660a4d7d66 100644 --- a/src/crimson/osd/replicated_recovery_backend.cc +++ b/src/crimson/osd/replicated_recovery_backend.cc @@ -1095,7 +1095,7 @@ void ReplicatedRecoveryBackend::submit_push_complete( ObjectStore::Transaction *t) { for (const auto& [oid, extents] : recovery_info.clone_subset) { - for (const auto [off, len] : extents) { + for (const auto& [off, len] : extents) { logger().debug(" clone_range {} {}~{}", oid, off, len); t->clone_range(coll->get_cid(), ghobject_t(oid), ghobject_t(recovery_info.soid), off, len, off); -- 2.39.5