From daa455cd168d62cd8fbcaba4d7aa79b56e68ef0d Mon Sep 17 00:00:00 2001 From: John Mulligan Date: Mon, 28 Feb 2022 15:43:47 -0500 Subject: [PATCH] mgr/nfs: fix unintentional recursion The `exports` property of the ExportMgr exists to cache the exports configuration found in the .nfs namespace. Using that property within the property method is probably not intentional and is probably only working due to the lucky construction of the _exports dict immediately after the None check so that the _exports dict is returned (and is a mutable type). Signed-off-by: John Mulligan --- src/pybind/mgr/nfs/export.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pybind/mgr/nfs/export.py b/src/pybind/mgr/nfs/export.py index 3ca4147123e..4e1a8251aa7 100644 --- a/src/pybind/mgr/nfs/export.py +++ b/src/pybind/mgr/nfs/export.py @@ -196,7 +196,7 @@ class ExportMgr: for cluster_id in known_cluster_ids(self.mgr): self.export_conf_objs = [] # type: List[Export] self._read_raw_config(cluster_id) - self.exports[cluster_id] = self.export_conf_objs + self._exports[cluster_id] = self.export_conf_objs log.info("Exports parsed successfully %s", self.exports.items()) return self._exports -- 2.47.3