From db7cd1a8b1aa0cc0901674e2d48d19c042156aee Mon Sep 17 00:00:00 2001 From: Tomer Haskalovitch Date: Wed, 8 Oct 2025 19:21:46 +0300 Subject: [PATCH] mgr/dashboard: ns list now support not passing nqn param Signed-off-by: Tomer Haskalovitch (cherry picked from commit 0419a1a17537917e01950745d3756591d83923da) --- src/pybind/mgr/dashboard/controllers/nvmeof.py | 4 ++-- src/pybind/mgr/dashboard/openapi.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/pybind/mgr/dashboard/controllers/nvmeof.py b/src/pybind/mgr/dashboard/controllers/nvmeof.py index b8e47a0e1d0..5836154e652 100644 --- a/src/pybind/mgr/dashboard/controllers/nvmeof.py +++ b/src/pybind/mgr/dashboard/controllers/nvmeof.py @@ -379,14 +379,14 @@ else: @EndpointDoc( "List all NVMeoF namespaces in a subsystem", parameters={ - "nqn": Param(str, "NVMeoF subsystem NQN"), + "nqn": Param(str, "NVMeoF subsystem NQN", True, None), "nsid": Param(str, "NVMeoF Namespace ID to filter by", True, None), "gw_group": Param(str, "NVMeoF gateway group", True, None), }, ) @convert_to_model(model.NamespaceList) @handle_nvmeof_error - def list(self, nqn: str, nsid: Optional[str] = None, + def list(self, nqn: Optional[str] = None, nsid: Optional[str] = None, gw_group: Optional[str] = None, traddr: Optional[str] = None): return NVMeoFClient(gw_group=gw_group, traddr=traddr).stub.list_namespaces( NVMeoFClient.pb2.list_namespaces_req(subsystem=nqn, diff --git a/src/pybind/mgr/dashboard/openapi.yaml b/src/pybind/mgr/dashboard/openapi.yaml index 097c11f5ddd..fd152a2fa97 100755 --- a/src/pybind/mgr/dashboard/openapi.yaml +++ b/src/pybind/mgr/dashboard/openapi.yaml @@ -9295,10 +9295,10 @@ paths: /api/nvmeof/subsystem/{nqn}/namespace: get: parameters: - - description: NVMeoF subsystem NQN + - allowEmptyValue: true + description: NVMeoF subsystem NQN in: path name: nqn - required: true schema: type: string - allowEmptyValue: true -- 2.39.5