From dbabbd03b79bcf58466e7a3e8b162cca3b42619a Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Wed, 20 Jan 2016 16:23:04 +0800 Subject: [PATCH] SubmittingPatches: add doc for "Fixes:" tag Signed-off-by: Kefu Chai --- SubmittingPatches.rst | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/SubmittingPatches.rst b/SubmittingPatches.rst index aa0013c4e9249..799b99ce14d90 100644 --- a/SubmittingPatches.rst +++ b/SubmittingPatches.rst @@ -376,7 +376,16 @@ the convenience of the 'pull request' feature. probably didn't even receive earlier versions of the patch. If the patch fixes a logged bug entry, refer to that bug entry by - number and URL. + number and URL. In particular, if this patch fixes one or more issues + tracked by http://tracker.ceph.com, consider adding a ``Fixes:`` tag to + connect this change to addressed issue(s). So a line saying :: + + Fixes: #12345 + + is added before the ``Signed-off-by:`` line stating that this commit + addresses http://tracker.ceph.com/issues/12345. It helps the reviewer to + get more context of this bug, so she/he can hence update the issue on + the bug tracker accordingly. 4. Separate your changes. -- 2.39.5