From dbf54df87941f538e73b672131018ce4baba338c Mon Sep 17 00:00:00 2001 From: Jeff Layton Date: Fri, 25 Aug 2017 08:31:47 -0400 Subject: [PATCH] client: reset unmounting flag to false when starting a new mount Once the "unmounting" flag goes to true, it never flips back to false. We don't have a lot of checks for "unmounting" in the code, but they're in some subtle places today and I plan to add more later. It's not clear to me whether it's possible (or advisable) to reuse a Client that has previously been unmounted. It most certainly won't work as expected today, and the checks I'll be adding will break it for sure. Make sure we clear the unmounting flag when we go to re-mount the Client. Signed-off-by: Jeff Layton (cherry picked from commit 3bc61f6c23a9ada5e2250f66e4df04a66dcfbacf) --- src/client/Client.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/client/Client.cc b/src/client/Client.cc index 60f3411370ecc..3595a32f35f3c 100644 --- a/src/client/Client.cc +++ b/src/client/Client.cc @@ -5691,6 +5691,8 @@ int Client::mount(const std::string &mount_root, const UserPerm& perms, return 0; } + unmounting = false; + int r = authenticate(); if (r < 0) { lderr(cct) << "authentication failed: " << cpp_strerror(r) << dendl; -- 2.39.5