From dd10b1e8348ffa1d87eaf7c0001cde7baac1b07b Mon Sep 17 00:00:00 2001 From: Josh Durgin Date: Mon, 24 Sep 2012 15:20:14 -0700 Subject: [PATCH] secret: close fd on error CID 717079: Resource leak (RESOURCE_LEAK) At (6): Handle variable "fd" going out of scope leaks the handle. Signed-off-by: Josh Durgin --- src/common/secret.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/common/secret.c b/src/common/secret.c index 0d2cfb61e379f..f37619a72dad2 100644 --- a/src/common/secret.c +++ b/src/common/secret.c @@ -38,6 +38,7 @@ int read_secret_from_file(const char *filename, char *secret, size_t max_len) len = safe_read(fd, secret, max_len); if (len <= 0) { perror("unable to read secret from file"); + close(fd); return -1; } end = secret; -- 2.39.5