From dd11042f969b94f7a461d02e1475794031c79f61 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Sat, 16 Aug 2014 12:42:33 -0700 Subject: [PATCH] os/FileStore: fix mount/remount force_sync race Consider: - mount - sync_entry is doing some work - umount - set force_sync = true - set done = true - sync_entry exits (due to done) - ..but does not set force_sync = false - mount - journal replay starts - sync_entry sees force_sync and does a commit while op_seq == 0 ...crash... Fixes: #9144 Backport: firefly, dumpling Signed-off-by: Sage Weil --- src/os/FileStore.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/os/FileStore.cc b/src/os/FileStore.cc index 4481c93f56b65..06eca20284f4c 100644 --- a/src/os/FileStore.cc +++ b/src/os/FileStore.cc @@ -1615,6 +1615,8 @@ int FileStore::umount() basedir_fd = -1; } + force_sync = false; + delete backend; backend = NULL; -- 2.39.5