From df8ba476d68a62f6e0449aa27c81f3effa1e0536 Mon Sep 17 00:00:00 2001 From: Alfredo Deza Date: Wed, 28 Nov 2018 16:09:49 -0500 Subject: [PATCH] ceph-volume tests.util ensure that both disk and device report is_device Signed-off-by: Alfredo Deza --- src/ceph-volume/ceph_volume/tests/util/test_device.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/ceph-volume/ceph_volume/tests/util/test_device.py b/src/ceph-volume/ceph_volume/tests/util/test_device.py index bcddfb44698..5a5e520d871 100644 --- a/src/ceph-volume/ceph_volume/tests/util/test_device.py +++ b/src/ceph-volume/ceph_volume/tests/util/test_device.py @@ -36,12 +36,19 @@ class TestDevice(object): disk = device.Device("/dev/nvme0n1") assert len(disk.vgs) == 1 - def test_is_device(self, device_info): + def test_device_is_device(self, device_info, pvolumes): data = {"/dev/sda": {"foo": "bar"}} lsblk = {"TYPE": "device"} device_info(devices=data, lsblk=lsblk) disk = device.Device("/dev/sda") - assert disk.is_device + assert disk.is_device is True + + def test_disk_is_device(self, device_info, pvolumes): + data = {"/dev/sda": {"foo": "bar"}} + lsblk = {"TYPE": "disk"} + device_info(devices=data, lsblk=lsblk) + disk = device.Device("/dev/sda") + assert disk.is_device is True def test_is_partition(self, device_info, pvolumes): data = {"/dev/sda": {"foo": "bar"}} -- 2.39.5