From e3cc60e6316b6b4b7223e39605421464b43eb73c Mon Sep 17 00:00:00 2001 From: Jakub Wilk Date: Wed, 1 Jul 2020 11:56:25 +0200 Subject: [PATCH] doc/dev/osd_internals: fix typos Signed-off-by: Jakub Wilk --- doc/dev/osd_internals/backfill_reservation.rst | 2 +- doc/dev/osd_internals/manifest.rst | 10 +++++----- doc/dev/osd_internals/partial_object_recovery.rst | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/dev/osd_internals/backfill_reservation.rst b/doc/dev/osd_internals/backfill_reservation.rst index 1220c6ba6ecce..ccab6837c4f18 100644 --- a/doc/dev/osd_internals/backfill_reservation.rst +++ b/doc/dev/osd_internals/backfill_reservation.rst @@ -41,7 +41,7 @@ to 253. Under ordinary circumstances a recovery is prioritized at 180 plus a value relative to the pool's recovery_priority. The total priority is limited to 219. -If a backfill is needed because the number of acting OSDs is less that min_size, +If a backfill is needed because the number of acting OSDs is less than min_size, a priority of 220 is used. The number of OSDs below min_size of the pool is added as well as a value relative to the pool's recovery_priority. The total priority is limited to 253. If a backfill is needed because a PG is undersized, diff --git a/doc/dev/osd_internals/manifest.rst b/doc/dev/osd_internals/manifest.rst index f41193b999fe9..2cd9c44865580 100644 --- a/doc/dev/osd_internals/manifest.rst +++ b/doc/dev/osd_internals/manifest.rst @@ -47,12 +47,12 @@ basic operations: * Demote cold rbd chunk to slow pool: 1. Read object, noting current user_version. - 2. In memory, run CDC implemenation to fingerprint object. + 2. In memory, run CDC implementation to fingerprint object. 3. Write out each resulting extent to an object in the cold pool using the CAS class. 4. Submit operation to base pool: - * ASSERT_VER with the user verion from the read to fail if the + * ASSERT_VER with the user version from the read to fail if the object has been mutated since the read. * SET_CHUNK for each of the extents to the corresponding object in the base pool. @@ -174,7 +174,7 @@ Testing We rely really heavily on randomized failure testing. As such, we need to extend that testing to include dedup/manifest support as well. Here's -a short list of the the touchpoints: +a short list of the touchpoints: * Thrasher tests like qa/suites/rados/thrash/workloads/cache-snaps.yaml @@ -372,7 +372,7 @@ Operations: The purpose of set_redirect is two. 1. Redirect all operation to the target object (like proxy) - 2. Cache when tier_promote is called (rediect will be cleared at this time). + 2. Cache when tier_promote is called (redirect will be cleared at this time). * set-chunk @@ -383,7 +383,7 @@ Operations: std::string tgt_oid, uint64_t tgt_offset, int flag = 0); rados -p base_pool set-chunk --target-pool - + Returns ENOENT if the object does not exist (TODO: why?) Returns EINVAL if the object already is a redirect. diff --git a/doc/dev/osd_internals/partial_object_recovery.rst b/doc/dev/osd_internals/partial_object_recovery.rst index db29131d296bf..747de839d8ff7 100644 --- a/doc/dev/osd_internals/partial_object_recovery.rst +++ b/doc/dev/osd_internals/partial_object_recovery.rst @@ -73,7 +73,7 @@ Therefore, we need to read_log and rebuild pg_missing_set. For example, pg_log i object aa: 28'108 {[0~12288, 16384~MAX], true} -Orignally, if bb,cc,dd is recovered, and aa is not. +Originally, if bb,cc,dd is recovered, and aa is not. So we need to rebuild pg_missing_set for object aa, and find aa is modified on version 28'108. If version in object_info is 26'96 < 28'108, -- 2.39.5