From e48353bbdd52a4288e9839d2a99fec1ef95147f3 Mon Sep 17 00:00:00 2001 From: John Spray Date: Tue, 3 Jul 2018 13:17:09 +0100 Subject: [PATCH] mgr: reduce log spam Several things at level 1 that shouldn't have been, especially the big dump of all possible commands every time we handle one. Signed-off-by: John Spray --- src/mgr/DaemonServer.cc | 7 +++++-- src/mgr/MgrStandby.cc | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mgr/DaemonServer.cc b/src/mgr/DaemonServer.cc index bb3ce29ae1fad..f6a1c709284ee 100644 --- a/src/mgr/DaemonServer.cc +++ b/src/mgr/DaemonServer.cc @@ -708,7 +708,11 @@ bool DaemonServer::handle_command(MCommand *m) con->mark_disposable(); } - dout(1) << "handle_command " << cpp_strerror(r) << " " << rs << dendl; + if (r == 0) { + dout(4) << __func__ << " success" << dendl; + } else { + derr << __func__ << " " << cpp_strerror(r) << " " << rs << dendl; + } if (con) { MCommandReply *reply = new MCommandReply(r, rs); reply->set_tid(m->get_tid()); @@ -1921,7 +1925,6 @@ bool DaemonServer::handle_command(MCommand *m) auto py_commands = py_modules.get_py_commands(); for (const auto &pyc : py_commands) { auto pyc_prefix = cmddesc_get_prefix(pyc.cmdstring); - dout(1) << "pyc_prefix: '" << pyc_prefix << "'" << dendl; if (pyc_prefix == prefix) { handler_name = pyc.module_name; break; diff --git a/src/mgr/MgrStandby.cc b/src/mgr/MgrStandby.cc index cee35c3dc3df7..22a7de3febe78 100644 --- a/src/mgr/MgrStandby.cc +++ b/src/mgr/MgrStandby.cc @@ -180,7 +180,7 @@ int MgrStandby::init() void MgrStandby::send_beacon() { assert(lock.is_locked_by_me()); - dout(1) << state_str() << dendl; + dout(4) << state_str() << dendl; std::list modules = py_module_registry.get_modules(); -- 2.39.5