From e57113480018d7e0a92ef811b6c9d1ee7b9b7e41 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sun, 6 Oct 2019 17:35:28 +0800 Subject: [PATCH] os/bluestore: move FileRef when constructing FileWriter no need to update the reference, we can just consume it. Signed-off-by: Kefu Chai --- src/os/bluestore/BlueFS.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/os/bluestore/BlueFS.h b/src/os/bluestore/BlueFS.h index 14dc7bdf906a3..683e992370488 100644 --- a/src/os/bluestore/BlueFS.h +++ b/src/os/bluestore/BlueFS.h @@ -158,13 +158,13 @@ public: std::array dirty_devs; FileWriter(FileRef f) - : file(f), + : file(std::move(f)), buffer_appender(buffer.get_page_aligned_appender( g_conf()->bluefs_alloc_size / CEPH_PAGE_SIZE)) { ++file->num_writers; iocv.fill(nullptr); dirty_devs.fill(false); - if (f->fnode.ino == 1) { + if (file->fnode.ino == 1) { write_hint = WRITE_LIFE_MEDIUM; } } @@ -250,7 +250,7 @@ public: MEMPOOL_CLASS_HELPERS(); FileRef file; - explicit FileLock(FileRef f) : file(f) {} + explicit FileLock(FileRef f) : file(std::move(f)) {} }; private: -- 2.39.5