From e5b1ae5554c4d8a20f9f0ff562b231ad0b0ba0ab Mon Sep 17 00:00:00 2001
From: David Zafman <dzafman@redhat.com>
Date: Tue, 25 Aug 2020 01:20:28 +0000
Subject: [PATCH] test: Use a config variable debug_version_for_testing

Signed-off-by: David Zafman <dzafman@redhat.com>
---
 src/common/admin_socket.cc                      | 2 +-
 src/common/options.cc                           | 4 ++++
 src/common/util.cc                              | 2 +-
 src/common/version.cc                           | 8 +++++++-
 src/common/version.h                            | 3 ++-
 src/crimson/admin/admin_socket.cc               | 2 +-
 src/global/signal_handler.cc                    | 2 +-
 src/libcephfs.cc                                | 2 +-
 src/mon/Monitor.cc                              | 2 +-
 src/tools/immutable_object_cache/CacheClient.cc | 2 +-
 10 files changed, 20 insertions(+), 9 deletions(-)

diff --git a/src/common/admin_socket.cc b/src/common/admin_socket.cc
index 01021d94193..33c528801de 100644
--- a/src/common/admin_socket.cc
+++ b/src/common/admin_socket.cc
@@ -631,7 +631,7 @@ public:
     } else {
       f->open_object_section("version");
       if (command == "version") {
-	f->dump_string("version", ceph_version_to_str());
+	f->dump_string("version", ceph_version_to_str(nullptr));
 	f->dump_string("release", ceph_release_to_str());
 	f->dump_string("release_type", ceph_release_type());
       } else if (command == "git_version") {
diff --git a/src/common/options.cc b/src/common/options.cc
index 8165692f95a..ac0cb9b3a0d 100644
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -8800,6 +8800,10 @@ std::vector<Option> get_mds_client_options() {
     .set_description("Size of thread pool for ASIO completions")
     .add_tag("client"),
 
+    Option("debug_version_for_testing", Option::TYPE_STR, Option::LEVEL_DEV)
+    .set_default("")
+    .set_description("Override ceph_version_short for testing"),
+
     Option("client_shutdown_timeout", Option::TYPE_SECS, Option::LEVEL_ADVANCED)
     .set_flag(Option::FLAG_RUNTIME)
     .set_default(30)
diff --git a/src/common/util.cc b/src/common/util.cc
index 6cb1f02733c..7e9ca49f039 100644
--- a/src/common/util.cc
+++ b/src/common/util.cc
@@ -229,7 +229,7 @@ void collect_sys_info(map<string, string> *m, CephContext *cct)
 {
   // version
   (*m)["ceph_version"] = pretty_version_to_str();
-  (*m)["ceph_version_short"] = ceph_version_to_str();
+  (*m)["ceph_version_short"] = ceph_version_to_str(cct);
   (*m)["ceph_release"] = ceph_release_to_str();
 
   #ifndef _WIN32
diff --git a/src/common/version.cc b/src/common/version.cc
index 4d5c001b2e0..24d1c8a843e 100644
--- a/src/common/version.cc
+++ b/src/common/version.cc
@@ -23,8 +23,14 @@
 #define _STR(x) #x
 #define STRINGIFY(x) _STR(x)
 
-const char *ceph_version_to_str(void)
+// Keep ver.c_str() available
+static std::string ver;
+
+const char *ceph_version_to_str(CephContext *cct)
 {
+  if (cct) ver = cct->_conf.get_val<std::string>("debug_version_for_testing");
+  if (ver.size() > 0)
+    return ver.c_str();
   return CEPH_GIT_NICE_VER;
 }
 
diff --git a/src/common/version.h b/src/common/version.h
index 066fa914623..067148a060d 100644
--- a/src/common/version.h
+++ b/src/common/version.h
@@ -16,9 +16,10 @@
 #define CEPH_COMMON_VERSION_H
 
 #include <string>
+#include "common/ceph_context.h"
 
 // Return a string describing the Ceph version
-const char *ceph_version_to_str(void);
+const char *ceph_version_to_str(CephContext *cct);
 
 // Return a string with the Ceph release
 const char *ceph_release_to_str(void);
diff --git a/src/crimson/admin/admin_socket.cc b/src/crimson/admin/admin_socket.cc
index 13782ac7e37..27cdcf132fc 100644
--- a/src/crimson/admin/admin_socket.cc
+++ b/src/crimson/admin/admin_socket.cc
@@ -297,7 +297,7 @@ class VersionHook final : public AdminSocketHook {
   {
     unique_ptr<Formatter> f{Formatter::create(format, "json-pretty", "json-pretty")};
     f->open_object_section("version");
-    f->dump_string("version", ceph_version_to_str());
+    f->dump_string("version", ceph_version_to_str(nullptr));
     f->dump_string("release", ceph_release_to_str());
     f->dump_string("release_type", ceph_release_type());
     f->close_section();
diff --git a/src/global/signal_handler.cc b/src/global/signal_handler.cc
index 0447f96e1b1..a9e9e28bf14 100644
--- a/src/global/signal_handler.cc
+++ b/src/global/signal_handler.cc
@@ -204,7 +204,7 @@ static void handle_fatal_signal(int signum)
 	now.gmtime(jf.dump_stream("timestamp"));
 	jf.dump_string("process_name", g_process_name);
 	jf.dump_string("entity_name", g_ceph_context->_conf->name.to_str());
-	jf.dump_string("ceph_version", ceph_version_to_str());
+	jf.dump_string("ceph_version", ceph_version_to_str(g_ceph_context));
 
 	struct utsname u;
 	r = uname(&u);
diff --git a/src/libcephfs.cc b/src/libcephfs.cc
index a17577ac7fc..7e280815a06 100644
--- a/src/libcephfs.cc
+++ b/src/libcephfs.cc
@@ -362,7 +362,7 @@ extern "C" void ceph_userperm_destroy(UserPerm *perm)
 extern "C" const char *ceph_version(int *pmajor, int *pminor, int *ppatch)
 {
   int major, minor, patch;
-  const char *v = ceph_version_to_str();
+  const char *v = ceph_version_to_str(nullptr);
 
   int n = sscanf(v, "%d.%d.%d", &major, &minor, &patch);
   if (pmajor)
diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc
index 279d786a60c..21c3f7b8d19 100644
--- a/src/mon/Monitor.cc
+++ b/src/mon/Monitor.cc
@@ -3638,7 +3638,7 @@ void Monitor::handle_command(MonOpRequestRef op)
       f.reset(Formatter::create("json-pretty"));
     f->open_object_section("report");
     f->dump_stream("cluster_fingerprint") << fingerprint;
-    f->dump_string("version", ceph_version_to_str());
+    f->dump_string("version", ceph_version_to_str(cct));
     f->dump_string("commit", git_version_to_str());
     f->dump_stream("timestamp") << ceph_clock_now();
 
diff --git a/src/tools/immutable_object_cache/CacheClient.cc b/src/tools/immutable_object_cache/CacheClient.cc
index e31713cd507..d378992719c 100644
--- a/src/tools/immutable_object_cache/CacheClient.cc
+++ b/src/tools/immutable_object_cache/CacheClient.cc
@@ -380,7 +380,7 @@ namespace immutable_obj_cache {
   int CacheClient::register_client(Context* on_finish) {
     ObjectCacheRequest* reg_req = new ObjectCacheRegData(RBDSC_REGISTER,
                                                          m_sequence_id++,
-                                                         ceph_version_to_str());
+                                                         ceph_version_to_str(m_cct));
     reg_req->encode();
 
     bufferlist bl;
-- 
2.39.5