From e6223872c58e492d3570335fd7f05bb52641837c Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Tue, 22 Nov 2022 11:56:36 +0800 Subject: [PATCH] crimson: print exceptions using exception.what() {fmt} does not support formatting exceptions until https://github.com/fmtlib/fmt/pull/3062/commits/76adb05a78a026b94c2ecadd20c00ae0c33c5a37 so we need to print them via exception.what(). Signed-off-by: Kefu Chai --- src/crimson/net/ProtocolV2.cc | 2 +- src/crimson/os/seastore/seastore_types.cc | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/crimson/net/ProtocolV2.cc b/src/crimson/net/ProtocolV2.cc index 0f36066db8dbb..2b41e868f0008 100644 --- a/src/crimson/net/ProtocolV2.cc +++ b/src/crimson/net/ProtocolV2.cc @@ -604,7 +604,7 @@ seastar::future<> ProtocolV2::client_auth(std::vector &allowed_methods return handle_auth_reply(); }); } catch (const crimson::auth::error& e) { - logger().error("{} get_initial_auth_request returned {}", conn, e); + logger().error("{} get_initial_auth_request returned {}", conn, e.what()); abort_in_close(*this, true); return seastar::now(); } diff --git a/src/crimson/os/seastore/seastore_types.cc b/src/crimson/os/seastore/seastore_types.cc index ef4f7f4e72eab..432539d73ea37 100644 --- a/src/crimson/os/seastore/seastore_types.cc +++ b/src/crimson/os/seastore/seastore_types.cc @@ -591,7 +591,7 @@ try_decode_records_header( journal_logger().debug( "try_decode_records_header: failed, " "cannot decode record_group_header_t, got {}.", - e); + e.what()); return std::nullopt; } if (header.segment_nonce != expected_nonce) { @@ -654,7 +654,7 @@ try_decode_record_headers( journal_logger().debug( "try_decode_record_headers: failed, " "cannot decode record_header_t, got {}.", - e); + e.what()); return std::nullopt; } } @@ -690,7 +690,7 @@ try_decode_extent_infos( journal_logger().debug( "try_decode_extent_infos: failed, " "cannot decode extent_info_t, got {}.", - e); + e.what()); return std::nullopt; } } @@ -734,7 +734,7 @@ try_decode_deltas( journal_logger().debug( "try_decode_deltas: failed, " "cannot decode delta_info_t, got {}.", - e); + e.what()); return std::nullopt; } } -- 2.39.5