From e68736961fa23ecabaef0fd51b138c3d21c5d76e Mon Sep 17 00:00:00 2001 From: Rishabh Dave Date: Wed, 10 Jun 2020 19:17:28 +0530 Subject: [PATCH] vstart_runner: set omit_sudo to True by default Let's set omit_sudo to True by default since we don't to run commands with sudo on developer's machine as far as possible. Signed-off-by: Rishabh Dave --- qa/tasks/vstart_runner.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qa/tasks/vstart_runner.py b/qa/tasks/vstart_runner.py index aae37a187d5..14cdb28f4bc 100644 --- a/qa/tasks/vstart_runner.py +++ b/qa/tasks/vstart_runner.py @@ -356,9 +356,12 @@ class LocalRemote(object): def run(self, **kwargs): return self._do_run(**kwargs) + # XXX: omit_sudo is set to True since using sudo can change the ownership + # of files which becomes problematic for following executions of + # vstart_runner.py. def _do_run(self, args, check_status=True, wait=True, stdout=None, stderr=None, cwd=None, stdin=None, logger=None, label=None, - env=None, timeout=None, omit_sudo=False): + env=None, timeout=None, omit_sudo=True): args = self._perform_checks_and_return_list_of_args(args, omit_sudo) # We have to use shell=True if any run.Raw was present, e.g. && -- 2.39.5