From e69e50a859acebe0bf854c12a71bfe745e0c1cf6 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Mon, 17 Sep 2018 14:09:17 +0800 Subject: [PATCH] rpm: use updated gperftools make sure we only build with the higher version of gperftools on distros where both 2.4 and 2.6.1 are packaged. see https://git.centos.org/summary/rpms!gperftools.git . at the time of writing, gperftools 2.6.1 is packaged for CentOS/RHEL 7, if gperftools (>= 2.4) is required by Ceph, and user already has this version installed, when new Ceph packages are installed, the updated gperftools 2.6.1 version won't be installed as a dependency. when launching Ceph compiled with tcmalloc enabled, we will have symbol lookup error: ceph-osd: undefined symbol: _ZdaPvm so, by bumping up the required version of gperftools, the updated gperftools will be installed. see https://software.opensuse.org/package/gperftools, openSUSE/SLE offer 2.5. so they are safe at this moment. Fixes: http://tracker.ceph.com/issues/35969 Signed-off-by: Kefu Chai --- ceph.spec.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ceph.spec.in b/ceph.spec.in index 15eefaee73bba..328f61f634cee 100644 --- a/ceph.spec.in +++ b/ceph.spec.in @@ -149,8 +149,13 @@ BuildRequires: gcc-c++ %endif BuildRequires: gdbm %if 0%{with tcmalloc} +%if 0%{?fedora} || 0%{?rhel} +BuildRequires: gperftools-devel >= 2.6.1 +%endif +%if 0%{?suse_version} BuildRequires: gperftools-devel >= 2.4 %endif +%endif BuildRequires: jq BuildRequires: leveldb-devel > 1.2 BuildRequires: libaio-devel -- 2.39.5