From e7422fe741de594d2134feb04f35fb21977d7b79 Mon Sep 17 00:00:00 2001 From: Patrick Donnelly Date: Thu, 2 May 2024 20:49:22 -0400 Subject: [PATCH] mon/MDSMonitor: add note about missing metadata inclusion There is a "client_count" metadata on the health warning that apparently was intended to be used for aggregating warnings but never was. Add a TODO item for that. Signed-off-by: Patrick Donnelly (cherry picked from commit 6517b704e311fd24dbf5bfbdec2ddd23b17d4092) (cherry picked from commit c5e59168761928980869c612af21dd033808d76c) --- src/mon/MDSMonitor.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mon/MDSMonitor.cc b/src/mon/MDSMonitor.cc index 0ac5060f79c54..88894d73fc887 100644 --- a/src/mon/MDSMonitor.cc +++ b/src/mon/MDSMonitor.cc @@ -275,6 +275,7 @@ void MDSMonitor::encode_pending(MonitorDBStore::TransactionRef t) } pending.get_health_checks(&new_checks); for (auto& p : new_checks.checks) { + // TODO: handle "client_count" metadata when summarizing p.second.summary = std::regex_replace( p.second.summary, std::regex("%num%"), -- 2.39.5