From e79c9d3f51970fbe275087e92e468205f70e6f12 Mon Sep 17 00:00:00 2001
From: Avan Thakkar <athakkar@localhost.localdomain>
Date: Thu, 20 May 2021 05:27:29 +0530
Subject: [PATCH] mgr/dashboard: fix API docs link

Fixes: https://tracker.ceph.com/issues/50890
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
---
 .../dashboard-help/dashboard-help.component.html  | 15 ++++-----------
 .../dashboard-help/dashboard-help.component.ts    |  8 +-------
 2 files changed, 5 insertions(+), 18 deletions(-)

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/dashboard-help/dashboard-help.component.html b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/dashboard-help/dashboard-help.component.html
index 161e1f0c3b0..766645fa7e7 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/dashboard-help/dashboard-help.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/dashboard-help/dashboard-help.component.html
@@ -1,11 +1,3 @@
-<form #docsForm
-      action="/docs"
-      target="_blank"
-      method="post">
-  <input type="hidden"
-         name="token" />
-</form>
-
 <div ngbDropdown
      placement="bottom-right">
   <a ngbDropdownToggle
@@ -22,9 +14,10 @@
        href="{{ docsUrl }}"
        target="_blank"
        i18n>documentation</a>
-    <button ngbDropdownItem
-            (click)="goToApiDocs()"
-            i18n>API</button>
+    <a ngbDropdownItem
+       href="/docs"
+       target="_blank"
+       i18n>API</a>
     <button ngbDropdownItem
             (click)="openAboutModal()"
             i18n>About</button>
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/dashboard-help/dashboard-help.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/dashboard-help/dashboard-help.component.ts
index a76275bbec9..910a613335b 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/dashboard-help/dashboard-help.component.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/dashboard-help/dashboard-help.component.ts
@@ -1,4 +1,4 @@
-import { Component, OnInit, ViewChild } from '@angular/core';
+import { Component, OnInit } from '@angular/core';
 
 import { NgbModalRef } from '@ng-bootstrap/ng-bootstrap';
 
@@ -13,8 +13,6 @@ import { AboutComponent } from '../about/about.component';
   styleUrls: ['./dashboard-help.component.scss']
 })
 export class DashboardHelpComponent implements OnInit {
-  @ViewChild('docsForm', { static: true })
-  docsFormElement: any;
   docsUrl: string;
   modalRef: NgbModalRef;
   icons = Icons;
@@ -30,8 +28,4 @@ export class DashboardHelpComponent implements OnInit {
   openAboutModal() {
     this.modalRef = this.modalService.show(AboutComponent, null, { size: 'lg' });
   }
-
-  goToApiDocs() {
-    this.docsFormElement.nativeElement.submit();
-  }
 }
-- 
2.39.5