From e7d095f281cde79e1b117deb837b2e87d1550846 Mon Sep 17 00:00:00 2001
From: Volker Theile <vtheile@suse.com>
Date: Tue, 11 Aug 2020 14:53:56 +0200
Subject: [PATCH] mgr/dashboard: Strange iSCSI discovery auth behavior

Disable 'autocomplete' for the user and password form fields.

Fixes: https://tracker.ceph.com/issues/46900

Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 4e9c88649de2ac7ea0ad43613fe247f08a623299)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-discovery-modal/iscsi-target-discovery-modal.component.html
- line 24: span class "invalid feedback" is not available in nautilus, keeping "help-block" instead
---
 .../iscsi-target-discovery-modal.component.html      | 12 ++++++++----
 .../iscsi-target-form.component.html                 |  6 ++++++
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-discovery-modal/iscsi-target-discovery-modal.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-discovery-modal/iscsi-target-discovery-modal.component.html
index 9fe64e83171..57f49484959 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-discovery-modal/iscsi-target-discovery-modal.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-discovery-modal/iscsi-target-discovery-modal.component.html
@@ -19,7 +19,8 @@
             <input id="user"
                    class="form-control"
                    formControlName="user"
-                   type="text">
+                   type="text"
+                   autocomplete="off">
             <span class="help-block"
                   *ngIf="discoveryForm.showError('user', formDir, 'required')"
                   i18n>This field is required.</span>
@@ -42,7 +43,8 @@
               <input id="password"
                      class="form-control"
                      formControlName="password"
-                     type="password">
+                     type="password"
+                     autocomplete="new-password">
 
               <span class="input-group-btn">
                 <button type="button"
@@ -77,7 +79,8 @@
             <input id="mutual_user"
                    class="form-control"
                    formControlName="mutual_user"
-                   type="text">
+                   type="text"
+                   autocomplete="off">
 
             <span class="help-block"
                   *ngIf="discoveryForm.showError('mutual_user', formDir, 'required')"
@@ -101,7 +104,8 @@
               <input id="mutual_password"
                      class="form-control"
                      formControlName="mutual_password"
-                     type="password">
+                     type="password"
+                     autocomplete="new-password">
 
               <span class="input-group-btn">
                 <button type="button"
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.html
index a165d5627e6..0b0afa1a9df 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.html
@@ -214,6 +214,7 @@
             <div class="col-sm-9">
               <input class="form-control"
                      type="text"
+                     autocomplete="off"
                      id="target_user"
                      name="target_user"
                      formControlName="user" />
@@ -277,6 +278,7 @@
             <div class="col-sm-9">
               <input class="form-control"
                      type="text"
+                     autocomplete="off"
                      id="target_mutual_user"
                      name="target_mutual_user"
                      formControlName="mutual_user" />
@@ -393,6 +395,7 @@
                       <input [id]="'user' + ii"
                              class="form-control"
                              formControlName="user"
+                             autocomplete="off"
                              type="text">
                       <span class="help-block"
                             *ngIf="initiator.showError('user', formDir, 'required')"
@@ -416,6 +419,7 @@
                         <input [id]="'password' + ii"
                                class="form-control"
                                formControlName="password"
+                               autocomplete="new-password"
                                type="password">
 
                         <span class="input-group-btn">
@@ -452,6 +456,7 @@
                       <input [id]="'mutual_user' + ii"
                              class="form-control"
                              formControlName="mutual_user"
+                             autocomplete="off"
                              type="text">
 
                       <span class="help-block"
@@ -476,6 +481,7 @@
                         <input [id]="'mutual_password' + ii"
                                class="form-control"
                                formControlName="mutual_password"
+                               autocomplete="new-password"
                                type="password">
 
                         <span class="input-group-btn">
-- 
2.47.3