From e7da8e951d38843bc97386b60c7b0d4f9f76be8f Mon Sep 17 00:00:00 2001 From: Jianpeng Ma Date: Fri, 24 Jul 2020 08:52:14 +0800 Subject: [PATCH] os/bluestore/BlueFS: avoid useless ceph_clock_now() call. The overhead of utime_t constructor utime_t() is less than ceph_clock_now(). Signed-off-by: Jianpeng Ma --- src/os/bluestore/BlueFS.cc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/os/bluestore/BlueFS.cc b/src/os/bluestore/BlueFS.cc index 9589e02d9a1..c645ffb33ad 100644 --- a/src/os/bluestore/BlueFS.cc +++ b/src/os/bluestore/BlueFS.cc @@ -2922,8 +2922,10 @@ void BlueFS::wait_for_aio(FileWriter *h) { // NOTE: this is safe to call without a lock, as long as our reference is // stable. - dout(10) << __func__ << " " << h << dendl; - utime_t start = ceph_clock_now(); + utime_t start; + lgeneric_subdout(cct, bluefs, 10) << __func__; + start = ceph_clock_now(); + *_dout << " " << h << dendl; for (auto p : h->iocv) { if (p) { p->aio_wait(); @@ -3252,8 +3254,10 @@ void BlueFS::sync_metadata(bool avoid_compact) if (log_t.empty() && dirty_files.empty()) { dout(10) << __func__ << " - no pending log events" << dendl; } else { - dout(10) << __func__ << dendl; - utime_t start = ceph_clock_now(); + utime_t start; + lgeneric_subdout(cct, bluefs, 10) << __func__; + start = ceph_clock_now(); + *_dout << dendl; flush_bdev(); // FIXME? _flush_and_sync_log(l); dout(10) << __func__ << " done in " << (ceph_clock_now() - start) << dendl; -- 2.39.5