From e911e14cab478637042d223f0a5772a8c839e86f Mon Sep 17 00:00:00 2001
From: Orit Wasserman <owasserm@redhat.com>
Date: Fri, 8 Jan 2016 13:51:50 +0100
Subject: [PATCH] rgw: use refrence in read_clear_modified

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
---
 src/rgw/rgw_bucket.cc   | 4 ++--
 src/rgw/rgw_bucket.h    | 2 +-
 src/rgw/rgw_metadata.cc | 4 ++--
 src/rgw/rgw_metadata.h  | 2 +-
 src/rgw/rgw_rados.cc    | 4 ++--
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/rgw/rgw_bucket.cc b/src/rgw/rgw_bucket.cc
index cb8e90b990abb..b1df3f7d9ca9b 100644
--- a/src/rgw/rgw_bucket.cc
+++ b/src/rgw/rgw_bucket.cc
@@ -1608,10 +1608,10 @@ void RGWDataChangesLog::mark_modified(int shard_id, rgw_bucket_shard& bs)
   modified_shards[shard_id].insert(key);
 }
 
-void RGWDataChangesLog::read_clear_modified(map<int, set<string> > *modified)
+void RGWDataChangesLog::read_clear_modified(map<int, set<string> > &modified)
 {
   RWLock::WLocker wl(modified_lock);
-  modified->swap(modified_shards);
+  modified.swap(modified_shards);
   modified_shards.clear();
 }
 
diff --git a/src/rgw/rgw_bucket.h b/src/rgw/rgw_bucket.h
index a5a6763051aa3..3ac03e5114152 100644
--- a/src/rgw/rgw_bucket.h
+++ b/src/rgw/rgw_bucket.h
@@ -483,7 +483,7 @@ public:
                list<rgw_data_change_log_entry>& entries, LogMarker& marker, bool *ptruncated);
 
   void mark_modified(int shard_id, rgw_bucket_shard& bs);
-  void read_clear_modified(map<int, set<string> > *modified);
+  void read_clear_modified(map<int, set<string> > &modified);
 
   bool going_down();
 };
diff --git a/src/rgw/rgw_metadata.cc b/src/rgw/rgw_metadata.cc
index b961aa761b40a..9e263e4dbc08f 100644
--- a/src/rgw/rgw_metadata.cc
+++ b/src/rgw/rgw_metadata.cc
@@ -291,10 +291,10 @@ void RGWMetadataLog::mark_modified(int shard_id)
   modified_shards.insert(shard_id);
 }
 
-void RGWMetadataLog::read_clear_modified(set<int> *modified)
+void RGWMetadataLog::read_clear_modified(set<int> &modified)
 {
   RWLock::WLocker wl(lock);
-  modified->swap(modified_shards);
+  modified.swap(modified_shards);
   modified_shards.clear();
 }
 
diff --git a/src/rgw/rgw_metadata.h b/src/rgw/rgw_metadata.h
index a0bcf463d944d..58b1f3922cc95 100644
--- a/src/rgw/rgw_metadata.h
+++ b/src/rgw/rgw_metadata.h
@@ -189,7 +189,7 @@ public:
 
   int update_shards(list<int>& shards);
 
-  void read_clear_modified(set<int> *modified);
+  void read_clear_modified(set<int> &modified);
 };
 
 struct LogStatusDump {
diff --git a/src/rgw/rgw_rados.cc b/src/rgw/rgw_rados.cc
index 72abdd937be38..7f102bbf5d565 100644
--- a/src/rgw/rgw_rados.cc
+++ b/src/rgw/rgw_rados.cc
@@ -2815,7 +2815,7 @@ int RGWMetaNotifier::process()
 
   RGWMetadataLog *log = store->meta_mgr->get_log();
 
-  log->read_clear_modified(&shards);
+  log->read_clear_modified(shards);
 
   if (shards.empty()) {
     return 0;
@@ -2850,7 +2850,7 @@ int RGWDataNotifier::process()
 
   map<int, set<string> > shards;
 
-  store->data_log->read_clear_modified(&shards);
+  store->data_log->read_clear_modified(shards);
 
   if (shards.empty()) {
     return 0;
-- 
2.39.5