From ea4ae6d2f17ae8dcfb3d6f215d53b3f82a99270d Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Thu, 21 Apr 2022 06:31:21 +0800 Subject: [PATCH] cmake/modules: use exact version of python3 when finding cython * CMakeLists.txt: always pass "EXACT" to find_package(Python3). because per cmake document, "EXACT" only takes effect when _FIND_VERSION_COUNT is greater than 1, where is "Python3". see also cmake/modules/FindPython/Support.cmake * cmake/modules/AddCephTest.cmake: drop redundant find_package(Python3) calls. since Python3 is a mandatory requirement for building Ceph, we only need a single call of find_package(Python3..) in the top of the source tree. the only possible case to repeat it is to ensure that we have the correct version of Python3 used in following CMake script. but there is no need to repeat it if we just want to ensure that we have a python3 interpretor in place. * cmake/modules/Distutils.cmake: always pass "EXACT" to find_package(Python3). we should always pass EXACT to find_package() when finding python3, this is a follow-up of e2babdfae8c99f39f99a7c8a8f966299b2e62b19 Signed-off-by: Kefu Chai --- CMakeLists.txt | 6 +----- cmake/modules/AddCephTest.cmake | 2 -- cmake/modules/Distutils.cmake | 2 +- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 42ab137775d73..d491a20e6f621 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -475,12 +475,8 @@ option(WITH_CEPHFS "CephFS is enabled" ON) if(NOT WIN32) # Please specify 3.[0-7] if you want to build with a certain version of python3. set(WITH_PYTHON3 "3" CACHE STRING "build with specified python3 version") -if(NOT WITH_PYTHON3 STREQUAL "3") - set(find_python3_exact "EXACT") -endif() -find_package(Python3 ${WITH_PYTHON3} ${find_python3_exact} REQUIRED +find_package(Python3 ${WITH_PYTHON3} EXACT REQUIRED COMPONENTS Interpreter Development) -unset(find_python3_exact) option(WITH_MGR "ceph-mgr is enabled" ON) if(WITH_MGR) diff --git a/cmake/modules/AddCephTest.cmake b/cmake/modules/AddCephTest.cmake index 0df7125b50833..46d3a1b4cb813 100644 --- a/cmake/modules/AddCephTest.cmake +++ b/cmake/modules/AddCephTest.cmake @@ -38,7 +38,6 @@ if(WITH_GTEST_PARALLEL) BUILD_COMMAND "" INSTALL_COMMAND "") add_dependencies(tests gtest-parallel_ext) - find_package(Python3 QUIET REQUIRED) set(GTEST_PARALLEL_COMMAND ${Python3_EXECUTABLE} ${gtest_parallel_source_dir}/gtest-parallel) endif() @@ -70,7 +69,6 @@ function(add_tox_test name) list(APPEND tox_envs py3) endif() string(REPLACE ";" "," tox_envs "${tox_envs}") - find_package(Python3 QUIET REQUIRED) add_test( NAME setup-venv-for-${name} COMMAND ${CMAKE_SOURCE_DIR}/src/tools/setup-virtualenv.sh --python=${Python3_EXECUTABLE} ${venv_path} diff --git a/cmake/modules/Distutils.cmake b/cmake/modules/Distutils.cmake index d3aff02cd51c9..192c8c3efe2c6 100644 --- a/cmake/modules/Distutils.cmake +++ b/cmake/modules/Distutils.cmake @@ -6,7 +6,7 @@ include(CMakeParseArguments) # the building host happens to have a higher version of python3, that version # would be picked up instead by find_package(Python3). and that is not want we # expect. -find_package(Python3 ${WITH_PYTHON3} +find_package(Python3 ${WITH_PYTHON3} EXACT QUIET REQUIRED COMPONENTS Interpreter) -- 2.39.5