From eac559f47460ff59b580862b89c7c4fe8c48e3ca Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Sat, 13 Jul 2013 08:38:40 -0700 Subject: [PATCH] mon: drop win_election() _reset() kludge and strengthen assertions This is only there for the benefit of win_standalone_election(), but it doesn't need it, it clutters the code, and weakens our assertions. Now the only win_election() callers are win_standalone_election() (which is a single path that just did _reset()) and from the elector. Signed-off-by: Sage Weil --- src/mon/Monitor.cc | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc index c801886eb452c..b28a5c071ea25 100644 --- a/src/mon/Monitor.cc +++ b/src/mon/Monitor.cc @@ -1457,20 +1457,15 @@ epoch_t Monitor::get_epoch() void Monitor::win_election(epoch_t epoch, set& active, uint64_t features) { - if (!is_electing()) { - state = STATE_ELECTING; - _reset(); - } - + dout(10) << __func__ << " epoch " << epoch << " quorum " << active + << " features " << features << dendl; + assert(is_electing()); state = STATE_LEADER; leader_since = ceph_clock_now(g_ceph_context); leader = rank; quorum = active; quorum_features = features; outside_quorum.clear(); - dout(10) << "win_election, epoch " << epoch << " quorum is " << quorum - << " features are " << quorum_features - << dendl; clog.info() << "mon." << name << "@" << rank << " won leader election with quorum " << quorum << "\n"; -- 2.39.5