From ee42629c37e0fc8a037b721f7393e525e95b523e Mon Sep 17 00:00:00 2001 From: Manish M Yathnalli Date: Wed, 21 Jun 2023 13:29:41 +0530 Subject: [PATCH] cephfs-journal-tool: disambiguate usage of all keyword (in tool help). The fs:all for rank option description was confusing. It seemd like the fs was optional, but it is mandatory. This change modifies the help message to reflect the correct way to use all in the --rank option. Fixes: https://tracker.ceph.com/issues/61753 Signed-off-by: Manish M Yathnalli (cherry picked from commit 52c033f85e274c86bd75f0eb902a32d86356094e) --- src/tools/cephfs/JournalTool.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/cephfs/JournalTool.cc b/src/tools/cephfs/JournalTool.cc index d972f8341f668..6bca9bb08167b 100644 --- a/src/tools/cephfs/JournalTool.cc +++ b/src/tools/cephfs/JournalTool.cc @@ -62,7 +62,7 @@ void JournalTool::usage() << " : [summary|list|binary|json] [--path ]\n" << "\n" << "General options:\n" - << " --rank=filesystem:mds-rank|all Journal rank (mandatory)\n" + << " --rank=filesystem:{mds-rank|all} journal rank or \"all\" ranks (mandatory)\n" << " --journal= Journal type (purge_queue means\n" << " this journal is used to queue for purge operation,\n" << " default is mdlog, and only mdlog support event mode)\n" -- 2.39.5