From ef25ba39207c2e387c1ff5f6f5c07d4a579e5fd1 Mon Sep 17 00:00:00 2001 From: Josh Durgin Date: Wed, 23 Dec 2015 16:47:54 -0800 Subject: [PATCH] rbd: add helgrind to valgrind subsuite This checks locking problems. This can be a separate facet for workunits, but for now it requires a manual 2nd configuration for rbd_fsx. Signed-off-by: Josh Durgin --- suites/rbd/valgrind/validator/helgrind.yaml | 4 ++++ suites/rbd/valgrind/validator/memcheck.yaml | 4 ++++ suites/rbd/valgrind/workloads/c_api_tests.yaml | 1 - suites/rbd/valgrind/workloads/c_api_tests_with_journal.yaml | 1 - .../rbd/valgrind/workloads/c_api_tests_with_object_map.yaml | 1 - suites/rbd/valgrind/workloads/fsx_helgrind.yaml | 5 +++++ suites/rbd/valgrind/workloads/python_api_tests.yaml | 1 - .../valgrind/workloads/python_api_tests_with_journal.yaml | 1 - .../valgrind/workloads/python_api_tests_with_object_map.yaml | 1 - 9 files changed, 13 insertions(+), 6 deletions(-) create mode 100644 suites/rbd/valgrind/validator/helgrind.yaml create mode 100644 suites/rbd/valgrind/validator/memcheck.yaml create mode 100644 suites/rbd/valgrind/workloads/fsx_helgrind.yaml diff --git a/suites/rbd/valgrind/validator/helgrind.yaml b/suites/rbd/valgrind/validator/helgrind.yaml new file mode 100644 index 0000000000000..327492a18eb3e --- /dev/null +++ b/suites/rbd/valgrind/validator/helgrind.yaml @@ -0,0 +1,4 @@ +overrides: + workunit: + env: + VALGRIND: "helgrind" diff --git a/suites/rbd/valgrind/validator/memcheck.yaml b/suites/rbd/valgrind/validator/memcheck.yaml new file mode 100644 index 0000000000000..abb299179931e --- /dev/null +++ b/suites/rbd/valgrind/validator/memcheck.yaml @@ -0,0 +1,4 @@ +overrides: + workunit: + env: + VALGRIND: "memcheck" diff --git a/suites/rbd/valgrind/workloads/c_api_tests.yaml b/suites/rbd/valgrind/workloads/c_api_tests.yaml index 7f4309fe2a017..188ddc56c6078 100644 --- a/suites/rbd/valgrind/workloads/c_api_tests.yaml +++ b/suites/rbd/valgrind/workloads/c_api_tests.yaml @@ -5,4 +5,3 @@ tasks: - rbd/test_librbd.sh env: RBD_FEATURES: "1" - VALGRIND: "memcheck" diff --git a/suites/rbd/valgrind/workloads/c_api_tests_with_journal.yaml b/suites/rbd/valgrind/workloads/c_api_tests_with_journal.yaml index 255637aed3974..0f760f21b5574 100644 --- a/suites/rbd/valgrind/workloads/c_api_tests_with_journal.yaml +++ b/suites/rbd/valgrind/workloads/c_api_tests_with_journal.yaml @@ -5,4 +5,3 @@ tasks: - rbd/test_librbd.sh env: RBD_FEATURES: "127" - VALGRIND: "memcheck" diff --git a/suites/rbd/valgrind/workloads/c_api_tests_with_object_map.yaml b/suites/rbd/valgrind/workloads/c_api_tests_with_object_map.yaml index 8eb0bd40a6674..fef368b9bc438 100644 --- a/suites/rbd/valgrind/workloads/c_api_tests_with_object_map.yaml +++ b/suites/rbd/valgrind/workloads/c_api_tests_with_object_map.yaml @@ -5,4 +5,3 @@ tasks: - rbd/test_librbd.sh env: RBD_FEATURES: "13" - VALGRIND: "memcheck" diff --git a/suites/rbd/valgrind/workloads/fsx_helgrind.yaml b/suites/rbd/valgrind/workloads/fsx_helgrind.yaml new file mode 100644 index 0000000000000..08cdc2abc7c42 --- /dev/null +++ b/suites/rbd/valgrind/workloads/fsx_helgrind.yaml @@ -0,0 +1,5 @@ +tasks: +- rbd_fsx: + clients: [client.0] + size: 134217728 + valgrind: [--tool=helgrind] diff --git a/suites/rbd/valgrind/workloads/python_api_tests.yaml b/suites/rbd/valgrind/workloads/python_api_tests.yaml index ae05c2d2b9546..a7b3ce7d3e61c 100644 --- a/suites/rbd/valgrind/workloads/python_api_tests.yaml +++ b/suites/rbd/valgrind/workloads/python_api_tests.yaml @@ -5,4 +5,3 @@ tasks: - rbd/test_librbd_python.sh env: RBD_FEATURES: "1" - VALGRIND: "memcheck" diff --git a/suites/rbd/valgrind/workloads/python_api_tests_with_journal.yaml b/suites/rbd/valgrind/workloads/python_api_tests_with_journal.yaml index d57abb18edf16..07b3d9f23a646 100644 --- a/suites/rbd/valgrind/workloads/python_api_tests_with_journal.yaml +++ b/suites/rbd/valgrind/workloads/python_api_tests_with_journal.yaml @@ -5,4 +5,3 @@ tasks: - rbd/test_librbd_python.sh env: RBD_FEATURES: "127" - VALGRIND: "memcheck" diff --git a/suites/rbd/valgrind/workloads/python_api_tests_with_object_map.yaml b/suites/rbd/valgrind/workloads/python_api_tests_with_object_map.yaml index 0a989eeb2b66a..ede74cd8d595e 100644 --- a/suites/rbd/valgrind/workloads/python_api_tests_with_object_map.yaml +++ b/suites/rbd/valgrind/workloads/python_api_tests_with_object_map.yaml @@ -5,4 +5,3 @@ tasks: - rbd/test_librbd_python.sh env: RBD_FEATURES: "13" - VALGRIND: "memcheck" -- 2.39.5