From f2dda43c9ed4fda9cfa87362514985ee79e0ae15 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Wed, 27 Mar 2013 12:59:41 -0700 Subject: [PATCH] osd: EINVAL when rmw_flags is 0 A broken client (e.g., v0.56) can send a request that ends up with an rmw_flags of 0. Treat this as invalid and return EINVAL. Fixes: #4556 Signed-off-by: Sage Weil --- src/osd/OSD.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc index 521237712171..6b9057994961 100644 --- a/src/osd/OSD.cc +++ b/src/osd/OSD.cc @@ -6532,5 +6532,8 @@ int OSD::init_op_flags(OpRequestRef op) } } + if (op->rmw_flags == 0) + return -EINVAL; + return 0; } -- 2.47.3