From f2f7dfbdab01eb14ca64e39fd3b2e63c46852293 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Mon, 19 Jul 2021 12:55:57 +0800 Subject: [PATCH] cmake: require CMake v3.16 since we dropped the support of bionic, we now have the luxury of using newer CMake! and by using CMake 3.16, we now have access to * add_compile_definitions(), which was introduced in cmake 3.12 also, drop the comment of > remove cmake/modules/FindPython* once 3.12 is required because we need to support python 3.10 in future, better off keeping the FindPython files around, so we can backport cmake changes from upstream when necessary. we are allowed to bump up the CMake's required to 3.16, because: - ubuntu focal ships with cmake 3.16.3 - RHEL/CentOS8's AppStream has cmake 3.18 Signed-off-by: Kefu Chai --- CMakeLists.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index d6ad17bbf84..6c6f647bd50 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,5 +1,4 @@ -cmake_minimum_required(VERSION 3.10.2) -# remove cmake/modules/FindPython* once 3.12 is required +cmake_minimum_required(VERSION 3.16) project(ceph VERSION 17.0.0 -- 2.39.5