From f3ce75c16422122a0b5eeca94be14310711798ce Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Tue, 14 Apr 2015 09:32:22 -0700 Subject: [PATCH] mon: fix min variance calc in 'osd df' If the reweight is 0, ignore the osd for the purposes of calculating the min. Signed-off-by: Sage Weil --- src/mon/OSDMonitor.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc index 306f84e1800a..5c5ecaed58a6 100644 --- a/src/mon/OSDMonitor.cc +++ b/src/mon/OSDMonitor.cc @@ -652,9 +652,11 @@ protected: dump_item(qi, reweight, kb, kb_used, kb_avail, util, var, f); - if (!qi.is_bucket()) { - if (min_var < 0 || var < min_var) min_var = var; - if (max_var < 0 || var > max_var) max_var = var; + if (!qi.is_bucket() && reweight > 0) { + if (min_var < 0 || var < min_var) + min_var = var; + if (max_var < 0 || var > max_var) + max_var = var; double dev = util - average_util; dev *= dev; -- 2.47.3