From f463ef78d77b11b5ad78b31e9a3a88d0a6e62bca Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Fri, 22 Mar 2013 13:25:23 -0700 Subject: [PATCH] mkcephfs: make remote temp directory name unique The predictable file name is a security problem. CVE-2013-1882 Reported-by: Michael Scherer Signed-off-by: Sage Weil Reviewed-by: Dan Mick --- src/mkcephfs.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mkcephfs.in b/src/mkcephfs.in index 9c01cb0f0a6fc..1b532c294e51f 100644 --- a/src/mkcephfs.in +++ b/src/mkcephfs.in @@ -476,7 +476,8 @@ if [ $allhosts -eq 1 ]; then check_host || continue if [ -n "$ssh" ]; then - rdir="/tmp/mkfs.ceph.$$" + unique=`dd if=/dev/urandom bs=16 count=1 2>/dev/null | md5sum | awk '{print $1}'` + rdir="/tmp/mkfs.ceph.$unique" echo pushing conf and monmap to $host:$rdir do_cmd "mkdir -p $rdir" scp -q $dir/conf $host:$rdir -- 2.39.5