From f520fa6f38a25e2d0ff0c00bbe56f02365ac0176 Mon Sep 17 00:00:00 2001
From: Radoslaw Zarzynski <rzarzynski@mirantis.com>
Date: Sun, 17 Apr 2016 16:24:37 +0200
Subject: [PATCH] rgw: eradicate rgw_swift_verify_signed_token.

Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
---
 src/rgw/rgw_swift_auth.cc | 78 ---------------------------------------
 src/rgw/rgw_swift_auth.h  |  5 ---
 2 files changed, 83 deletions(-)

diff --git a/src/rgw/rgw_swift_auth.cc b/src/rgw/rgw_swift_auth.cc
index 41c5f8193e62a..43816b7a41a4a 100644
--- a/src/rgw/rgw_swift_auth.cc
+++ b/src/rgw/rgw_swift_auth.cc
@@ -10,7 +10,6 @@
 #include "auth/Crypto.h"
 
 #include "rgw_client_io.h"
-#include "rgw_swift.h"
 #include "rgw_http_client.h"
 #include "include/str_list.h"
 
@@ -344,83 +343,6 @@ static int encode_token(CephContext *cct, string& swift_user, string& key,
   return ret;
 }
 
-int rgw_swift_verify_signed_token(CephContext *cct, RGWRados *store,
-				  const char *token, RGWUserInfo& info,
-				  string *pswift_user)
-{
-  if (strncmp(token, "AUTH_rgwtk", 10) != 0)
-    return -EINVAL;
-
-  token += 10;
-
-  int len = strlen(token);
-  if (len & 1) {
-    dout(0) << "NOTICE: failed to verify token: invalid token length len="
-	    << len << dendl;
-    return -EINVAL;
-  }
-
-  bufferptr p(len/2);
-  int ret = hex_to_buf(token, p.c_str(), len);
-  if (ret < 0)
-    return ret;
-
-  bufferlist bl;
-  bl.append(p);
-
-  bufferlist::iterator iter = bl.begin();
-
-  uint64_t nonce;
-  utime_t expiration;
-  string swift_user;
-
-  try {
-    ::decode(swift_user, iter);
-    ::decode(nonce, iter);
-    ::decode(expiration, iter);
-  } catch (buffer::error& err) {
-    dout(0) << "NOTICE: failed to decode token: caught exception" << dendl;
-    return -EINVAL;
-  }
-  utime_t now = ceph_clock_now(cct);
-  if (expiration < now) {
-    dout(0) << "NOTICE: old timed out token was used now=" << now
-	    << " token.expiration=" << expiration << dendl;
-    return -EPERM;
-  }
-
-  if ((ret = rgw_get_user_info_by_swift(store, swift_user, info)) < 0)
-    return ret;
-
-  dout(10) << "swift_user=" << swift_user << dendl;
-
-  map<string, RGWAccessKey>::iterator siter = info.swift_keys.find(swift_user);
-  if (siter == info.swift_keys.end())
-    return -EPERM;
-  RGWAccessKey& swift_key = siter->second;
-
-  bufferlist tok;
-  ret = build_token(swift_user, swift_key.key, nonce, expiration, tok);
-  if (ret < 0)
-    return ret;
-
-  if (tok.length() != bl.length()) {
-    dout(0) << "NOTICE: tokens length mismatch: bl.length()=" << bl.length()
-	    << " tok.length()=" << tok.length() << dendl;
-    return -EPERM;
-  }
-
-  if (memcmp(tok.c_str(), bl.c_str(), tok.length()) != 0) {
-    char buf[tok.length() * 2 + 1];
-    buf_to_hex((const unsigned char *)tok.c_str(), tok.length(), buf);
-    dout(0) << "NOTICE: tokens mismatch tok=" << buf << dendl;
-    return -EPERM;
-  }
-  *pswift_user = swift_user;
-
-  return 0;
-}
-
 
 /* AUTH_rgwtk (signed token): engine */
 bool RGWSignedTokenAuthEngine::is_applicable() const noexcept
diff --git a/src/rgw/rgw_swift_auth.h b/src/rgw/rgw_swift_auth.h
index 8798a9d9fcfce..1dd63fe756279 100644
--- a/src/rgw/rgw_swift_auth.h
+++ b/src/rgw/rgw_swift_auth.h
@@ -123,11 +123,6 @@ public:
 };
 
 
-extern int rgw_swift_verify_signed_token(CephContext *cct,
-                                         RGWRados *store,
-                                         const char *token,
-                                         rgw_swift_auth_info& auth_info);
-
 class RGW_SWIFT_Auth_Get : public RGWOp {
 public:
   RGW_SWIFT_Auth_Get() {}
-- 
2.39.5