From f59066195fdaa807b5b5c1f4d3a652b9c519ed93 Mon Sep 17 00:00:00 2001
From: Ankit <51ankitkp@gmail.com>
Date: Wed, 12 Mar 2025 23:15:55 +0530
Subject: [PATCH] mgr/dashboard:fixed issue with notification icon

Fixes:https://tracker.ceph.com/issues/70253
Signed-off-by: Ankit Kumar <51ankitkp@gmail.com>
---
 .../core/navigation/navigation/navigation.component.html    | 5 +++--
 .../app/core/navigation/navigation/navigation.component.ts  | 6 +++++-
 .../navigation/notifications/notifications.component.html   | 2 +-
 .../navigation/notifications/notifications.component.ts     | 4 ----
 4 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html
index a544bbcdb43..9e40d53b4fc 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html
@@ -33,8 +33,9 @@
       <cds-header-navigation>
         <cd-language-selector class="d-flex"></cd-language-selector>
       </cds-header-navigation>
-      <div class="cds--btn cds--btn--icon-only cds--header__action">
-        <cd-notifications (click)="toggleRightSidebar()"></cd-notifications>
+      <div class="cds--btn cds--btn--icon-only cds--header__action"
+           (click)="toggleSidebar()">
+        <cd-notifications></cd-notifications>
       </div>
       <div class="cds--btn cds--btn--icon-only cds--header__action">
         <cd-dashboard-help></cd-dashboard-help>
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.ts
index 55c9ab7e88d..1b9c0b73c1b 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.ts
@@ -14,6 +14,7 @@ import {
   FeatureTogglesMap$,
   FeatureTogglesService
 } from '~/app/shared/services/feature-toggles.service';
+import { NotificationService } from '~/app/shared/services/notification.service';
 import { PrometheusAlertService } from '~/app/shared/services/prometheus-alert.service';
 import { SummaryService } from '~/app/shared/services/summary.service';
 
@@ -49,6 +50,7 @@ export class NavigationComponent implements OnInit, OnDestroy {
   currentClusterName: string;
 
   constructor(
+    public notificationService: NotificationService,
     private authStorageService: AuthStorageService,
     private multiClusterService: MultiClusterService,
     private router: Router,
@@ -189,7 +191,9 @@ export class NavigationComponent implements OnInit, OnDestroy {
       }
     );
   }
-
+  toggleSidebar() {
+    this.notificationService.toggleSidebar();
+  }
   trackByFn(item: any) {
     return item;
   }
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notifications/notifications.component.html b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notifications/notifications.component.html
index f120234b9cd..f106e6647e3 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notifications/notifications.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notifications/notifications.component.html
@@ -1,7 +1,7 @@
 <a i18n-title
    title="Tasks and Notifications"
    [ngClass]="{ 'running': hasRunningTasks }"
-   (click)="toggleSidebar()">
+   >
   <svg cdsIcon="notification"
        size="20"
        title="notification"></svg>
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notifications/notifications.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notifications/notifications.component.ts
index 89c6c403794..b6e5fd41ab4 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notifications/notifications.component.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notifications/notifications.component.ts
@@ -40,8 +40,4 @@ export class NotificationsComponent implements OnInit, OnDestroy {
   ngOnDestroy(): void {
     this.subs.unsubscribe();
   }
-
-  toggleSidebar() {
-    this.notificationService.toggleSidebar();
-  }
 }
-- 
2.39.5