From f610380e7696642e8e33ca4c3690f67c7c67944d Mon Sep 17 00:00:00 2001 From: Eryu Guan Date: Mon, 21 Sep 2015 11:05:44 +1000 Subject: [PATCH] xfs/074: specify filesystem size in terms of size not block count When testing 512 block size xfs, xfs/074 fails as QA output created by 074 +fallocate: No space left on device Silence is golden That's because 40051712*512=20G < 30G. And quote from Dave: That was sized to give AGs of a specific size, which originally contributed to the problem being exposed. You should change the block count specification to a size specification so the filesysetm being made on 4k block size filesystems remains unchanged. size = 40051712b = 40051712 * 4096 = 164,051,812,352 = 156452m So set the filesystem size to 156452m explicitly. Suggested-by: Dave Chinner Signed-off-by: Eryu Guan Reviewed-by: Dave Chinner Signed-off-by: Dave Chinner --- tests/xfs/074 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/xfs/074 b/tests/xfs/074 index a571a341..9f24512e 100755 --- a/tests/xfs/074 +++ b/tests/xfs/074 @@ -62,7 +62,7 @@ mkdir -p $LOOP_MNT $XFS_IO_PROG -ft -c "truncate 1t" $LOOP_FILE >> $seqres.full LOOP_DEV=`_create_loop_device $LOOP_FILE` -_mkfs_dev -d size=40051712b,agcount=4 -l size=32m $LOOP_DEV +_mkfs_dev -d size=156452m,agcount=4 -l size=32m $LOOP_DEV _mount $LOOP_DEV $LOOP_MNT # Corrupt the BMBT by creating extents larger than MAXEXTLEN -- 2.39.5