From f80c976f8d636eb9ac49fc4f847388aa98eadb11 Mon Sep 17 00:00:00 2001
From: John Mulligan <jmulligan@redhat.com>
Date: Mon, 25 Sep 2023 13:58:35 -0400
Subject: [PATCH] cephadm: add some unit test coverage for deploying nfs, snmp

Signed-off-by: John Mulligan <jmulligan@redhat.com>
---
 src/cephadm/tests/test_deploy.py | 86 ++++++++++++++++++++++++++++++++
 1 file changed, 86 insertions(+)
 create mode 100644 src/cephadm/tests/test_deploy.py

diff --git a/src/cephadm/tests/test_deploy.py b/src/cephadm/tests/test_deploy.py
new file mode 100644
index 00000000000..6fd36cc6eb1
--- /dev/null
+++ b/src/cephadm/tests/test_deploy.py
@@ -0,0 +1,86 @@
+import pathlib
+import unittest
+from unittest import mock
+
+from .fixtures import (
+    cephadm_fs,
+    import_cephadm,
+    mock_podman,
+    with_cephadm_ctx,
+)
+
+
+_cephadm = import_cephadm()
+
+
+def test_deploy_nfs_container(cephadm_fs, monkeypatch):
+    _call = mock.MagicMock(return_value=('', '', 0))
+    monkeypatch.setattr('cephadmlib.container_types.call', _call)
+    _firewalld = mock.MagicMock()
+    _firewalld().external_ports.get.return_value = []
+    monkeypatch.setattr('cephadm.Firewalld', _firewalld)
+    fsid = 'b01dbeef-701d-9abe-0000-e1e5a47004a7'
+    with with_cephadm_ctx([]) as ctx:
+        ctx.container_engine = mock_podman()
+        ctx.fsid = fsid
+        ctx.name = 'nfs.fun'
+        ctx.image = 'quay.io/ceph/ceph:latest'
+        ctx.reconfig = False
+        ctx.config_blobs = {
+            'pool': 'foo',
+            'files': {
+                'ganesha.conf': 'FAKE',
+            },
+            'config': 'BALONEY',
+            'keyring': 'BUNKUS',
+        }
+        _cephadm._common_deploy(ctx)
+
+    with open(f'/var/lib/ceph/{fsid}/nfs.fun/unit.run') as f:
+        runfile_lines = f.read().splitlines()
+    assert 'podman' in runfile_lines[-1]
+    assert runfile_lines[-1].endswith('quay.io/ceph/ceph:latest -F -L STDERR')
+    _firewalld().open_ports.assert_called_with([2049])
+    with open(f'/var/lib/ceph/{fsid}/nfs.fun/config') as f:
+        assert f.read() == 'BALONEY'
+    with open(f'/var/lib/ceph/{fsid}/nfs.fun/keyring') as f:
+        assert f.read() == 'BUNKUS'
+    with open(f'/var/lib/ceph/{fsid}/nfs.fun/etc/ganesha/ganesha.conf') as f:
+        assert f.read() == 'FAKE'
+
+
+def test_deploy_snmp_container(cephadm_fs, monkeypatch):
+    _call = mock.MagicMock(return_value=('', '', 0))
+    monkeypatch.setattr('cephadmlib.container_types.call', _call)
+    _call_throws = mock.MagicMock(return_value=0)
+    monkeypatch.setattr(
+        'cephadmlib.container_types.call_throws', _call_throws
+    )
+    _firewalld = mock.MagicMock()
+    _firewalld().external_ports.get.return_value = []
+    monkeypatch.setattr('cephadm.Firewalld', _firewalld)
+    fsid = 'b01dbeef-701d-9abe-0000-e1e5a47004a7'
+    with with_cephadm_ctx([]) as ctx:
+        ctx.container_engine = mock_podman()
+        ctx.fsid = fsid
+        ctx.name = 'snmp-gateway.sunmop'
+        ctx.image = 'quay.io/aaabbb/snmp:latest'
+        ctx.reconfig = False
+        ctx.config_blobs = {
+            'destination': '192.168.100.10:8899',
+            'config': 'XXXXXXX',
+            'keyring': 'YYYYYY',
+        }
+        _cephadm._common_deploy(ctx)
+
+    with open(f'/var/lib/ceph/{fsid}/snmp-gateway.sunmop/unit.run') as f:
+        runfile_lines = f.read().splitlines()
+    assert 'podman' in runfile_lines[-1]
+    assert runfile_lines[-1].endswith(
+        'quay.io/aaabbb/snmp:latest --web.listen-address=:9464 --snmp.destination=192.168.100.10:8899 --snmp.version=V2c --log.level=info --snmp.trap-description-template=/etc/snmp_notifier/description-template.tpl'
+    )
+    _firewalld().open_ports.assert_not_called()
+    basedir = pathlib.Path(f'/var/lib/ceph/{fsid}/snmp-gateway.sunmop')
+    assert basedir.is_dir()
+    assert not (basedir / 'config').exists()
+    assert not (basedir / 'keyring').exists()
-- 
2.39.5