From f87ac52eaf793b25cc993c90c8e1deaa0b021cd8 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Fri, 31 Jul 2020 13:05:15 +0800 Subject: [PATCH] orchestra/cluster: be explicit that a positional argument is needed otherwise the caller may run into sh() missing 1 required positional argument: 'script' if the developer only check the function signature of Cluster.sh(). Signed-off-by: Kefu Chai --- teuthology/orchestra/cluster.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/teuthology/orchestra/cluster.py b/teuthology/orchestra/cluster.py index 50e078cd8e..dbc74de021 100644 --- a/teuthology/orchestra/cluster.py +++ b/teuthology/orchestra/cluster.py @@ -63,7 +63,7 @@ class Cluster(object): remotes = sorted(self.remotes.keys(), key=lambda rem: rem.name) return [remote.run(**kwargs) for remote in remotes] - def sh(self, **kwargs): + def sh(self, script, **kwargs): """ Run a command on all the nodes in this cluster. @@ -72,7 +72,7 @@ class Cluster(object): Returns a list of the command outputs correspondingly. """ remotes = sorted(self.remotes.keys(), key=lambda rem: rem.name) - return [remote.sh(**kwargs) for remote in remotes] + return [remote.sh(script, **kwargs) for remote in remotes] def write_file(self, file_name, content, sudo=False, perms=None, owner=None): """ -- 2.39.5