From f87caf3f9bab1861551182ba537d26423aa70a59 Mon Sep 17 00:00:00 2001
From: Guillaume Abrioux <gabrioux@redhat.com>
Date: Tue, 12 Dec 2017 11:28:36 +0100
Subject: [PATCH] client: don't make `osd_pool_default_pg_num` mandatory
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

making `osd_pool_default_pg_num` mandatory is a bit agressive and is
unrelated when you just want to create users keyrings.

Closes: #2241

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit a24fd1cfd9a2f5a5daa9bee1f533cd2da0cc8fe2)
Signed-off-by: Sébastien Han <seb@redhat.com>
---
 group_vars/clients.yml.sample                 | 1 +
 roles/ceph-client/defaults/main.yml           | 1 +
 roles/ceph-client/tasks/create_users_keys.yml | 1 +
 roles/ceph-client/tasks/main.yml              | 1 -
 4 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/group_vars/clients.yml.sample b/group_vars/clients.yml.sample
index b4fc87117..f29b23a71 100644
--- a/group_vars/clients.yml.sample
+++ b/group_vars/clients.yml.sample
@@ -25,6 +25,7 @@ dummy:
 # Generate a keyring using ceph-authtool CLI or python.
 # Eg:
 #  $ ceph-authtool --gen-print-key
+#  or
 #  $ python2 -c "import os ; import struct ; import time; import base64 ; key = os.urandom(16) ; header = struct.pack('<hiih',1,int(time.time()),0,len(key)) ; print base64.b64encode(header + key)"
 #keys:
 #  - { name: client.test, key: "ADD-KEYRING-HERE==", mon_cap: "allow r", osd_cap: "allow class-read object_prefix rbd_children, allow rwx pool=test", mode: "0600", acls: [] }
diff --git a/roles/ceph-client/defaults/main.yml b/roles/ceph-client/defaults/main.yml
index 37e43aa06..396bcd0ab 100644
--- a/roles/ceph-client/defaults/main.yml
+++ b/roles/ceph-client/defaults/main.yml
@@ -17,6 +17,7 @@ pools:
 # Generate a keyring using ceph-authtool CLI or python.
 # Eg:
 #  $ ceph-authtool --gen-print-key
+#  or
 #  $ python2 -c "import os ; import struct ; import time; import base64 ; key = os.urandom(16) ; header = struct.pack('<hiih',1,int(time.time()),0,len(key)) ; print base64.b64encode(header + key)"
 keys:
   - { name: client.test, key: "ADD-KEYRING-HERE==", mon_cap: "allow r", osd_cap: "allow class-read object_prefix rbd_children, allow rwx pool=test", mode: "0600", acls: [] }
diff --git a/roles/ceph-client/tasks/create_users_keys.yml b/roles/ceph-client/tasks/create_users_keys.yml
index 47fd2d4e6..ec8f722d3 100644
--- a/roles/ceph-client/tasks/create_users_keys.yml
+++ b/roles/ceph-client/tasks/create_users_keys.yml
@@ -51,6 +51,7 @@
   changed_when: false
   failed_when: false
   when:
+    - ceph_conf_overrides.get('global', {}).get('osd_pool_default_pg_num', False) != False
     - pools | length > 0
     - copy_admin_key
 
diff --git a/roles/ceph-client/tasks/main.yml b/roles/ceph-client/tasks/main.yml
index 2c91e7bd4..3a03bfe5d 100644
--- a/roles/ceph-client/tasks/main.yml
+++ b/roles/ceph-client/tasks/main.yml
@@ -6,4 +6,3 @@
   include: create_users_keys.yml
   when:
     - user_config
-    - ceph_conf_overrides.get('global', {}).get('osd_pool_default_pg_num', False) != False
-- 
2.39.5