From f98cc2256bbef3ee63d60cba965d3f64ad4ca743 Mon Sep 17 00:00:00 2001 From: "Darrick J. Wong" Date: Mon, 11 Feb 2019 18:17:48 -0800 Subject: [PATCH] inject: skip tests when knob dir exists but knob doesn't If the XFS error injection knob directory exists but the knob itself doesn't, then we know that this kernel doesn't support the knob and can skip the test. Signed-off-by: Darrick J. Wong Reviewed-by: Brian Foster Signed-off-by: Eryu Guan --- common/inject | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/common/inject b/common/inject index 903fb379..984ec209 100644 --- a/common/inject +++ b/common/inject @@ -62,6 +62,13 @@ _require_xfs_io_error_injection() knob="$(_find_xfs_mountdev_errortag_knob "${TEST_DEV}" "${type}")" test -w "${knob}" && return + # If the directory containing the sysfs error injection knob exists + # but the knob itself isn't usable, this kernel doesn't know about + # the knob. Skip the test. + if [ -d "$(dirname "${knob}")" ]; then + _notrun "XFS error injection $type unknown on this kernel." + fi + # NOTE: We can't actually test error injection here because xfs # hasn't always range checked the argument to xfs_errortag_add. # We also don't want to trip an error before we're ready to deal -- 2.39.5