From f99f3125ff76628e2525dca00bb7b983f941a08b Mon Sep 17 00:00:00 2001 From: Zhiqiang Wang Date: Fri, 20 Mar 2015 16:15:42 +0800 Subject: [PATCH] test: potential memory leak in FlushAioPP Should call the release function instead of deleting it to free librbd::RBD::AioCompletion and librbd::AioCompletion. Otherwise there is a potential memory leak. Signed-off-by: Zhiqiang Wang (cherry picked from commit ada7ec860cb7901c560c12a5af36dc7c23051b76) --- src/test/librbd/test_librbd.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/librbd/test_librbd.cc b/src/test/librbd/test_librbd.cc index b4ad6ca851d2e..2f2082660dd1d 100644 --- a/src/test/librbd/test_librbd.cc +++ b/src/test/librbd/test_librbd.cc @@ -1975,12 +1975,12 @@ TEST_F(TestLibRBD, FlushAioPP) ASSERT_EQ(0, image.aio_flush(flush_comp)); ASSERT_EQ(0, flush_comp->wait_for_complete()); ASSERT_EQ(1, flush_comp->is_complete()); - delete flush_comp; + flush_comp->release(); for (i = 0; i < num_aios; ++i) { librbd::RBD::AioCompletion *comp = write_comps[i]; ASSERT_EQ(1, comp->is_complete()); - delete comp; + comp->release(); } ASSERT_PASSED(validate_object_map, image); } -- 2.39.5