From fc0730037f49af2d5944a5f7707f4b3c512c9af0 Mon Sep 17 00:00:00 2001 From: Ilya Dryomov Date: Fri, 8 Apr 2022 15:53:38 +0200 Subject: [PATCH] librbd/cache/pwl: no need to set clean and empty in remove_pool_file() It is redundant -- the only caller sets both since commit 6593e31fff18 ("librbd/cache/pwl: correct cache state"). Signed-off-by: Ilya Dryomov (cherry picked from commit d64a3ae265897806809d9fa08ac72c549b4bca4f) --- src/librbd/cache/pwl/rwl/WriteLog.cc | 2 -- src/librbd/cache/pwl/ssd/WriteLog.cc | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/librbd/cache/pwl/rwl/WriteLog.cc b/src/librbd/cache/pwl/rwl/WriteLog.cc index 2dd60665ed5b3..f25094750a554 100644 --- a/src/librbd/cache/pwl/rwl/WriteLog.cc +++ b/src/librbd/cache/pwl/rwl/WriteLog.cc @@ -252,8 +252,6 @@ void WriteLog::remove_pool_file() { lderr(m_image_ctx.cct) << "failed to remove empty pool \"" << this->m_log_pool_name << "\": " << pmemobj_errormsg() << dendl; } else { - m_cache_state->clean = true; - m_cache_state->empty = true; m_cache_state->present = false; } } else { diff --git a/src/librbd/cache/pwl/ssd/WriteLog.cc b/src/librbd/cache/pwl/ssd/WriteLog.cc index 94beeaf6d7314..493f9019136d1 100644 --- a/src/librbd/cache/pwl/ssd/WriteLog.cc +++ b/src/librbd/cache/pwl/ssd/WriteLog.cc @@ -270,8 +270,6 @@ void WriteLog::remove_pool_file() { lderr(m_image_ctx.cct) << "failed to remove empty pool \"" << this->m_log_pool_name << "\": " << dendl; } else { - m_cache_state->clean = true; - m_cache_state->empty = true; m_cache_state->present = false; } } else { -- 2.39.5