From fc587d6caa2376f95fe15567bd632a2d4b8bb81f Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Wed, 7 Sep 2011 16:50:29 -0700 Subject: [PATCH] client: fix leaked Dir on rename Need to close old_dentry->dir if the dir is empty. This was introduced by ed7ebf35b124a236b88a478c33db82f015a8d4a4. Fixes: #1509 Signed-off-by: Sage Weil --- src/client/Client.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/client/Client.cc b/src/client/Client.cc index 01524ad1c468a..a386a15bffb14 100644 --- a/src/client/Client.cc +++ b/src/client/Client.cc @@ -602,7 +602,7 @@ Dentry *Client::insert_dentry_inode(Dir *dir, const string& dname, LeaseStat *dl if (!dn || dn->inode == 0) { in->get(); if (old_dentry) - unlink(old_dentry, true); + unlink(old_dentry, false); dn = link(dir, dname, in, dn); in->put(); if (set_offset) { -- 2.39.5