From fefdf284f68c5760a937d4387c8d5f785f5f60b6 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Thu, 16 Aug 2012 17:25:38 -0700 Subject: [PATCH] rbd: warn on 0-length secret Signed-off-by: Sage Weil --- src/rbd.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/rbd.cc b/src/rbd.cc index 79c513e289ec7..4419fbd5b8eb3 100644 --- a/src/rbd.cc +++ b/src/rbd.cc @@ -713,6 +713,8 @@ static int do_kernel_add(const char *poolname, const char *imgname, const char * r = set_kernel_secret(secret_str.c_str(), key_name); if (r >= 0) { + if (r == 0) + cerr << "warning: secret has length 0" << std::endl; oss << ",key=" << key_name; } else if (r == -ENODEV || r == -ENOSYS) { /* running against older kernel; fall back to secret= in options */ -- 2.39.5