From 5503cf9c54cc7d5a357b38af7eeb0eb56b6db0e6 Mon Sep 17 00:00:00 2001 From: Vallari Agrawal Date: Wed, 12 Jun 2024 22:43:30 +0530 Subject: [PATCH] teuthology/kill.py: Fix "TypeError: string indices must be integers" Fixes: https://tracker.ceph.com/issues/66440 Signed-off-by: Vallari Agrawal --- teuthology/kill.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/teuthology/kill.py b/teuthology/kill.py index bb5838c4f0..c78346fe2a 100755 --- a/teuthology/kill.py +++ b/teuthology/kill.py @@ -74,7 +74,7 @@ def kill_run(run_name, archive_base=None, owner=None, machine_type=None, return if owner is not None: targets = find_targets(run_name) - names = [t["name"] for t in targets] + names = [t for t in targets] lock_ops.unlock_safe(names, owner, run_name) report.try_mark_run_dead(run_name) @@ -233,11 +233,11 @@ def find_pids(run_name): def find_targets(run_name: str, job_id: Union[str, int, None] = None) -> dict: if job_id is not None: job_info = report.ResultsReporter().get_jobs(run_name, str(job_id)) - return job_info.get("targets", dict()) + return job_info.get("targets" or dict()) result = dict() run_info = report.ResultsReporter().get_jobs(run_name) for job_info in run_info: if job_info.get("status") not in ("running", "waiting"): continue - result.update(job_info.get("targets", dict())) + result.update(job_info.get("targets") or dict()) return result -- 2.39.5