From 03ec4be89ac2fca4405573f3aa47b4d41f8726f2 Mon Sep 17 00:00:00 2001 From: xie xingguo Date: Sat, 15 Oct 2016 10:53:43 +0800 Subject: [PATCH] os/bluestore: narrow scope of local variables Signed-off-by: xie xingguo --- src/os/bluestore/BlueStore.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc index eea0b0ed2e5f6..26b3490126524 100644 --- a/src/os/bluestore/BlueStore.cc +++ b/src/os/bluestore/BlueStore.cc @@ -8352,7 +8352,6 @@ int BlueStore::_clone(TransContext *txc, return -EINVAL; } - bufferlist bl; newo->exists = true; _assign_nid(txc, newo); @@ -8364,6 +8363,7 @@ int BlueStore::_clone(TransContext *txc, if (g_conf->bluestore_clone_cow) { _do_clone_range(txc, c, oldo, newo, 0, oldo->onode.size, 0); } else { + bufferlist bl; r = _do_read(c.get(), oldo, 0, oldo->onode.size, bl, 0); if (r < 0) goto out; @@ -8391,13 +8391,13 @@ int BlueStore::_clone(TransContext *txc, get_omap_tail(oldo->onode.omap_head, &tail); it->lower_bound(head); while (it->valid()) { - string key; if (it->key() >= tail) { dout(30) << __func__ << " reached tail" << dendl; break; } else { dout(30) << __func__ << " got header/data " << pretty_binary_string(it->key()) << dendl; + string key; rewrite_omap_key(newo->onode.omap_head, it->key(), &key); txc->t->set(PREFIX_OMAP, key, it->value()); } @@ -8533,7 +8533,6 @@ int BlueStore::_clone_range(TransContext *txc, << newo->oid << " from 0x" << std::hex << srcoff << "~" << length << " to offset 0x" << dstoff << std::dec << dendl; int r = 0; - bufferlist bl; if (srcoff + length > oldo->onode.size) { r = -EINVAL; @@ -8547,6 +8546,7 @@ int BlueStore::_clone_range(TransContext *txc, _do_zero(txc, c, newo, dstoff, length); _do_clone_range(txc, c, oldo, newo, srcoff, length, dstoff); } else { + bufferlist bl; r = _do_read(c.get(), oldo, srcoff, length, bl, 0); if (r < 0) goto out; -- 2.39.5