From 87cd4c7350d5e3f3521e455b3be14f53384b74ad Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Mon, 24 Oct 2016 19:21:15 +0200 Subject: [PATCH] qa/workunits/rados/test_rados_tool.sh: test for segv without --pool Ensure that the rados client binary doesn't segfault when specifying a number of parameters without a corresponding --pool parameter. Signed-off-by: David Disseldorp --- qa/workunits/rados/test_rados_tool.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/qa/workunits/rados/test_rados_tool.sh b/qa/workunits/rados/test_rados_tool.sh index 08306f6fbcd0..c0b6d8ceecc8 100755 --- a/qa/workunits/rados/test_rados_tool.sh +++ b/qa/workunits/rados/test_rados_tool.sh @@ -79,6 +79,12 @@ done TDIR=`mktemp -d -t test_rados_tool.XXXXXXXXXX` || die "mktemp failed" [ $KEEP_TEMP_FILES -eq 0 ] && trap "rm -rf ${TDIR}; exit" INT TERM EXIT +# ensure rados doesn't segfault without --pool +run_expect_nosignal "$RADOS_TOOL" --snap "asdf" ls +run_expect_nosignal "$RADOS_TOOL" --snapid "0" ls +run_expect_nosignal "$RADOS_TOOL" --object_locator "asdf" ls +run_expect_nosignal "$RADOS_TOOL" --namespace "asdf" ls + run_expect_succ "$RADOS_TOOL" mkpool "$POOL" # expb happens to be the empty export for legacy reasons -- 2.47.3