From 59fb7ae1543b5ff1d39b45ecc2b4423293fe9e32 Mon Sep 17 00:00:00 2001 From: Jos Collin Date: Sat, 22 Apr 2017 13:49:20 +0530 Subject: [PATCH] osdc: warning: comparison between signed and unsigned integer expressions MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The following warning appears during make. Fixed the review comments too. [ 28%] Building CXX object src/mds/CMakeFiles/mds.dir/__/osdc/Journaler.cc.o ./src/osdc/Journaler.cc: In member function ‘void Journaler::_do_flush(unsigned int)’: ./src/osdc/Journaler.cc:643:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (newlen < len) { ~~~~~~~^~~~~ Signed-off-by: Jos Collin --- src/osdc/Journaler.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/osdc/Journaler.cc b/src/osdc/Journaler.cc index 642b15be4306..7c1be262644b 100644 --- a/src/osdc/Journaler.cc +++ b/src/osdc/Journaler.cc @@ -640,7 +640,7 @@ void Journaler::_do_flush(unsigned amount) waiting_for_zero = true; return; } - if (newlen < len) { + if (static_cast(newlen) < len) { ldout(cct, 10) << "_do_flush wanted to do " << flush_pos << "~" << len << " but hit prezero_pos " << prezero_pos << ", will do " << flush_pos << "~" << newlen << dendl; -- 2.47.3