From f47baa86aa7bfbdbf59b1fe4686a235e3edbe8a3 Mon Sep 17 00:00:00 2001 From: amitkuma Date: Sun, 6 Aug 2017 23:11:10 +0530 Subject: [PATCH] messages: Initialization of uninitialized members varied classes Fixes the coverity issues: ** 1188168 Uninitialized scalar field CID 1188168 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member success is not initialized in this constructor nor in any functions that it calls. ** 1188169 Uninitialized scalar field 2. uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls. CID 1188169 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 4. uninit_member: Non-static class member min_epoch is not initialized in this constructor nor in any functions that it calls. ** 1188170 Uninitialized scalar field 2. uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls. CID 1188170 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 4. uninit_member: Non-static class member min_epoch is not initialized in this constructor nor in any functions that it calls. ** 1188171 Uninitialized scalar field 2. uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls. CID 1188171 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 4. uninit_member: Non-static class member min_epoch is not initialized in this constructor nor in any functions that it calls. ** 1188172 Uninitialized scalar field 2. uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls. CID 1188172 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 4. uninit_member: Non-static class member min_epoch is not initialized in this constructor nor in any functions that it calls. ** 1188173 Uninitialized scalar field 2. uninit_member: Non-static class member map_epoch is not initialized in this constructor nor in any functions that it calls. CID 1188173 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 4. uninit_member: Non-static class member min_epoch is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Amit Kumar amitkuma@redhat.com --- src/messages/MExportDirPrepAck.h | 2 +- src/messages/MOSDECSubOpRead.h | 2 +- src/messages/MOSDECSubOpReadReply.h | 2 +- src/messages/MOSDECSubOpWrite.h | 2 +- src/messages/MOSDECSubOpWriteReply.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/messages/MExportDirPrepAck.h b/src/messages/MExportDirPrepAck.h index bb9bb13778d5..d623d1acc096 100644 --- a/src/messages/MExportDirPrepAck.h +++ b/src/messages/MExportDirPrepAck.h @@ -20,7 +20,7 @@ class MExportDirPrepAck : public Message { dirfrag_t dirfrag; - bool success; + bool success = false; public: dirfrag_t get_dirfrag() { return dirfrag; } diff --git a/src/messages/MOSDECSubOpRead.h b/src/messages/MOSDECSubOpRead.h index de9317e45a63..48a283c20601 100644 --- a/src/messages/MOSDECSubOpRead.h +++ b/src/messages/MOSDECSubOpRead.h @@ -24,7 +24,7 @@ class MOSDECSubOpRead : public MOSDFastDispatchOp { public: spg_t pgid; - epoch_t map_epoch, min_epoch; + epoch_t map_epoch = 0, min_epoch = 0; ECSubRead op; int get_cost() const override { diff --git a/src/messages/MOSDECSubOpReadReply.h b/src/messages/MOSDECSubOpReadReply.h index 7ad931445c97..4cc3547400b5 100644 --- a/src/messages/MOSDECSubOpReadReply.h +++ b/src/messages/MOSDECSubOpReadReply.h @@ -24,7 +24,7 @@ class MOSDECSubOpReadReply : public MOSDFastDispatchOp { public: spg_t pgid; - epoch_t map_epoch, min_epoch; + epoch_t map_epoch = 0, min_epoch = 0; ECSubReadReply op; int get_cost() const override { diff --git a/src/messages/MOSDECSubOpWrite.h b/src/messages/MOSDECSubOpWrite.h index 72a272c6ab02..b1e6b8c361f9 100644 --- a/src/messages/MOSDECSubOpWrite.h +++ b/src/messages/MOSDECSubOpWrite.h @@ -24,7 +24,7 @@ class MOSDECSubOpWrite : public MOSDFastDispatchOp { public: spg_t pgid; - epoch_t map_epoch, min_epoch; + epoch_t map_epoch = 0, min_epoch = 0; ECSubWrite op; int get_cost() const override { diff --git a/src/messages/MOSDECSubOpWriteReply.h b/src/messages/MOSDECSubOpWriteReply.h index 778a13d79849..e7ca5233bed6 100644 --- a/src/messages/MOSDECSubOpWriteReply.h +++ b/src/messages/MOSDECSubOpWriteReply.h @@ -24,7 +24,7 @@ class MOSDECSubOpWriteReply : public MOSDFastDispatchOp { public: spg_t pgid; - epoch_t map_epoch, min_epoch; + epoch_t map_epoch = 0, min_epoch = 0; ECSubWriteReply op; int get_cost() const override { -- 2.47.3