From 6ec99f7a2044c42c4526111d1e1a8ec32d2ca555 Mon Sep 17 00:00:00 2001 From: Josh Durgin Date: Tue, 6 May 2014 11:18:28 -0700 Subject: [PATCH] librbd: check return value during snap_unprotect This would only fail if the header object was corrupted, so it's unlikely to occur in practice. Signed-off-by: Josh Durgin --- src/librbd/internal.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/librbd/internal.cc b/src/librbd/internal.cc index e56ef0897f48..1d0e43f4ac44 100644 --- a/src/librbd/internal.cc +++ b/src/librbd/internal.cc @@ -664,6 +664,11 @@ namespace librbd { ictx->header_oid, snap_id, RBD_PROTECTION_STATUS_UNPROTECTED); + if (r < 0) { + lderr(ictx->cct) << "snap_unprotect: error setting unprotected status" + << dendl; + goto reprotect_and_return_err; + } notify_change(ictx->md_ctx, ictx->header_oid, NULL, ictx); return 0; -- 2.47.3